Supports zone-configuration for load-balancer #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvmw
force-pushed
the
kvmw/zone-configuration
branch
from
27eebdf to
cebe723
Compare
mamachanko
approved these changes
Nov 5, 2024
kvmw
force-pushed
the
kvmw/zone-configuration
branch
from
cebe723 to
9ef4e56
Compare
Signed-off-by: kvmw <[email protected]>
kvmw
force-pushed
the
kvmw/zone-configuration
branch
from
9ef4e56 to
4fa67c3
Compare
mamachanko
approved these changes
Nov 5, 2024
csterwa
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new feature flag called
scs.starters.eureka.client.zone.configuration.enabledwhich isfalseby default.If the flag is enabled:
Eureka instance
zoneis set to full hostname of theservice-registrythis app is bound to. For exampleservice-registry-29f15513-9234-476d-b36b-a6ae0de548a4.foo.bar.io. By using the hostname, we can have multiple zones in a single CF/TAS org or even space.spring.cloud.loadbalancer.configurationsis set tozone-preference, to make sure load balancer is considering the service instances in the samezoneas clientzone, before other instances.