✨ Support multiple rule names for AppScan #428
Conversation
ryandens
commented
Jul 23, 2024
ryandens
commented
- ✨ support muitiple rule names in AppScan
- 💡 Improve docs for AppScan getRule accessor
|
| .toInstance(map.getOrDefault(providedAppScanScan.ruleName(), RuleSarif.EMPTY)); | ||
| } else if (providedAppScanScan.ruleNames().length > 0) { | ||
|
|
||
| RuleSarif ruleSarif = RuleSarif.EMPTY; |
There was a problem hiding this comment.
Not sure I understand this logic. We loop through the names and match/break on the first one?
I was expecting this would look much more like "merge N results together" kind of change.
There was a problem hiding this comment.
Typically, we see the different names as a result of different kinds of scans (e.g. from source or from a binary), so I wouldn't expect to see a SARIF with results from multiple of the names specified on the annotation in the same SARIF file.
In general, I thought we were trying to avoid merging SARIF at this stage?
There was a problem hiding this comment.
Ah, true. It will only be one or the other, you're right.
