Support simple patterns for codemod include/exclude #458
Conversation
src/codemodder/registry.py
Outdated
| base_codemods.pop(codemod.id, None) | ||
| if bool(sast_only) != bool(codemod.origin == "pixee"): | ||
| base_codemods[codemod.id] = codemod | ||
|
|
||
| # Remove duplicates and preserve order | ||
| return list(dict.fromkeys(base_codemods.values())) |
There was a problem hiding this comment.
The logic is so subtly changed so I'm going off passing unit tests but I think you can remove this list(dict.from_keys...) since that was necessary when base_codemods did this:
base_codemods[codemod.id] = codemod
base_codemods[codemod.name] = codemod
but since that was only necessary to log an excluded codemod and that's been removed, you can remove this duplication removal.
| not sast_only and codemod.origin == "pixee" | ||
| if ( | ||
| codemod.id in names | ||
| or (codemod.origin == "pixee" and codemod.name in names) |
There was a problem hiding this comment.
does this line accomplish this issue for excluded?
There was a problem hiding this comment.
Yes I think it does for the exclude case but I think we'd want to add more tests so we can keep it as a separate issue.
drdavella
force-pushed
the
glob-codemod-ids
branch
from
e7fd202
to
31d88f2
Compare
|
Yes sorry I see that this was complicated and I'm just not sure it's necessary so I was able to simplify it. |
Overview
Support simple patterns for codemod include/exclude CLI flags
Description
sast_onlybut I left it as-is for this PRCloses #316