Add wildcards to codemod selection arguments #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds a wildcarding ability to pass to `--codemod-include` (and exclude).
drdavella
requested changes
Mar 1, 2024
cli.md
Outdated
| - All codemod rules are loaded by default unless `--codemode-include` specifies a list. `-codemode-exclude` works off all default codemods. | ||
| - Specifying a `--codemod-include`or `--codemod-exclude` that references a non-existent codemod will result in an error | ||
| - Specifying a `--codemod-include` or `--codemod-exclude` that references a non-existent codemod will result in an error | ||
| - You can specify a simple wildcard for `--codemod-include` and `--codemod-exclude` (e.g., `--codemod-include=acme:*`). If this pattern doesn't match any codemods, an error will result. |
There was a problem hiding this comment.
I think it should be valid to pass a pattern that doesn't match any codemods. I'm also wondering whether we should revisit the behavior for explicitly selecting a non-existent codemod. It feels to me like maybe this should be a warning instead of an error? Does this make anything easier where upstream users are concerned?
There was a problem hiding this comment.
Maybe not -- a warning sounds ok.
drdavella
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a wildcarding ability to pass to
--codemod-include(and exclude).