Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This codemod replaces all instances of functions in the
random
module (e.g.random.random()
with their, much more secure, equivalents from thesecrets
module (e.g.secrets.SystemRandom().random()
).There is significant algorithmic complexity in getting computers to generate genuinely unguessable random bits. The
random.random()
function uses a method of pseudo-random number generation that unfortunately emits fairly predictable numbers.If the numbers it emits are predictable, then it's obviously not safe to use in cryptographic operations, file name creation, token construction, password generation, and anything else that's related to security. In fact, it may affect security even if it's not directly obvious.
Switching to a more secure version is simple and the changes look something like this:
More reading
Powered by: pixeebot (codemod ID: pixee:python/secure-random)