Added show raw mail function #739

ghost · 2016-07-03T17:48:11Z

No description provided.

ayoyoness · 2016-07-04T09:02:22Z

Hi @eikeniebuhr and @krunoknego,

Thanks a lot for working on this.
It looks good.
I have a few comments:

Could you please make a separate PR for the Swedish translation? It is great but It is better if it goes on its own pull request as it is clearly not related.
It would be good if you can squash the commits touching the same domain, and give a more meaningful commit message. Small commits are great but in the sense that things that naturally belong to each other should go together. For example, there are two successive 'pr fix' commits that does css... there are a number of successive commits for translations... maybe one -separate- commit each for the frontend and backend codes, if possible to separate.
The CI is breaking. There is jshint error: app/js/services/mail_service.js: line 292, col 8, Missing semicolon.
It would also be great if you add tests on both the frontend and backend
I think "get raw mail" sounds better than "get mail raw", doesn't it? :)

Thanks again,
We're so excited you got the ball rolling on this.

ghost · 2016-07-04T09:11:58Z

@mnandri Thanks for the reply. We'll resolve the issues as soon as possible. :)

ayoyoness · 2016-07-04T13:26:51Z

@krunoknego
great!
You can find us on IRC (#pixelated on irc.freenode.net), with a slightly faster response time... if you need any help or have queries.

Conflicts: web-ui/app/locales/de_DE/translation.json web-ui/app/locales/es_ES/translation.json

tuliocasagrande · 2016-07-11T13:43:08Z

Hello @eikeniebuhr and @krunoknego,

Thanks a lot for working on this.
I just wanted to add something concerning translations.

Recently we moved to Transifex for managing our translations. It's easier for maintenance and receiving non-developers contributions.

We decided not to work with translations using git commits. So could you please submit your sv_SE translation to https://www.transifex.com/pixelated/pixelated-user-agent/dashboard/. The only thing you need to git commit is the en_US new tag "get-mail-raw": "Get mail raw",.

Please feel free to contact me if you need any help.

thaissiqueira · 2016-12-30T19:57:19Z

Hey @eikeniebuhr and @krunoknego,

How are you doing?

I just installed your fork in my machine and I loved your contribution! (I'm bit late :P)
I saw that you did some of @ayoyoness and @tuliocasagrande's suggestions and will be awesome if you could do the remainder of them.
To keep this code easier to maintain, as a community code, it's super important for us to follow the contributor's guide.
I really hope this merge could be done soon.

ghost · 2017-01-11T10:59:17Z

Hello @thaissiqueira,

Sorry for taking it so long to respond. We will resolve all the issues that are still remaining and hopefully we'll have something that is merge ready either today or tomorrow.

thaissiqueira · 2017-01-11T19:47:35Z

Cool! Glad for hear it. Thanks for the collaboration.

…agent

ghost · 2017-01-13T00:00:56Z

It would seem that the CI build is failing because of the code style. I've used autopep8 to automatically fix it (https://pypi.python.org/pypi/autopep8). Can you guide me with what library/command I should fix the code style?

anikarni · 2017-01-13T12:42:12Z

Actually, @krunoknego , this is because we changed how we run tests in our snap-ci and your PR wasn't updated. I'm fixing that and you should have a better feedback in a few minutes.

anikarni

Hi @krunoknego and @eikeniebuhr , again, thanks so much for the PR and we really hope to merge it soon.

I fixed snap-ci, so it should be okay now (sorry about that), but I still have a few small comments. These should be quick fixes (mostly just about plain text).

Lastly, I just wanted to ask if you could add a functional test for this. How does that sound?

anikarni · 2017-01-13T12:48:58Z

service/README.md

@@ -1,4 +1,4 @@
-Pixelated User Agent Service
+ixelated User Agent Service


The "P" here has been removed, I believe, accidentally.

anikarni · 2017-01-13T12:52:34Z

service/pixelated/bitmask_libraries/provider.py

        if not os.path.isdir(path):
-            os.makedirs(path, 0700)
+            os.makedirs(path, 0o700)


Any reason this changed?

anikarni · 2017-01-13T12:55:55Z

service/pixelated/resources/mail_resource.py

@@ -4,7 +4,7 @@
 from twisted.web.resource import Resource
 from twisted.web.server import NOT_DONE_YET

-from pixelated.resources import respond_json_deferred, BaseResource, handle_error_deferred
+from pixelated.resources import respond_json_deferred, respond_json, BaseResource, handle_error_deferred


I believe the import that was added here wasn't actually needed or used. Or is it just not in the diff?

anikarni · 2017-01-13T12:56:41Z

service/pixelated/resources/mails_resource.py

@@ -145,7 +152,8 @@ def getChild(self, action, request):
        if action == 'unread':
            return MailsUnreadResource(_mail_service)

-    def _build_mails_response(self, (mails, total)):
+    def _build_mails_response(self, xxx_todo_changeme):


Is this variable name supposed to have been changed? hehe

anikarni · 2017-01-13T13:03:38Z

web-ui/app/locales/pt_BR/translation.json

@@ -28,6 +28,7 @@
    "mark-as-read": "Marcar como lida",
    "mark-as-unread": "Marcar como não lida",
    "delete": "Deletar",
+    "get-raw-mail": "Get raw mail",


This can be "Mostrar original"

anikarni · 2017-01-13T13:03:49Z

web-ui/app/locales/en_US/translation.json

@@ -28,6 +28,7 @@
    "mark-as-read": "Mark as read",
    "mark-as-unread": "Mark as unread",
    "delete": "Delete",
+    "get-raw-mail": "Get raw mail",


This can be "View raw email"

KrunoKnego and others added 11 commits June 30, 2016 00:26

Download raw email

9fc2b6f

Downloading raw mail

818b91f

clean up

5aaac44

clean up and changed download raw function

36e813f

delete comma

dd24883

clean up

3f77fa7

pr fix

c5e9f8c

pr fix

d6faf47

pr fix

8a38f14

pr fix translation

3a460ea

Fixed conflicts

1c42fb4

re-nobre added the PR label Jul 4, 2016

Update mail_service.js

768bc6e

re-nobre mentioned this pull request Jul 5, 2016

Show raw mail #490

Open

re-nobre assigned ayoyoness Jul 7, 2016

KrunoKnego added 3 commits July 8, 2016 00:03

Merge remote-tracking branch 'upstream/master'

689c174

Conflicts: web-ui/app/locales/de_DE/translation.json web-ui/app/locales/es_ES/translation.json

Renamed to get raw mail

77210be

Renamed to get raw mail

69a1387

thaissiqueira force-pushed the master branch from ac6dc74 to 6ee8dd1 Compare August 25, 2016 22:06

KrunoKnego added 3 commits January 13, 2017 00:40

Merge branch 'master' of https://github.com/pixelated/pixelated-user-…

7aafe12

…agent

Ran autopep8

821c271

Ran autopep8

ab600f0

anikarni reviewed Jan 13, 2017

View reviewed changes

anikarni unassigned ayoyoness Jan 26, 2017

anikarni removed the PR label May 15, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added show raw mail function #739

Added show raw mail function #739

ghost commented Jul 3, 2016

ayoyoness commented Jul 4, 2016

ghost commented Jul 4, 2016

ayoyoness commented Jul 4, 2016 •

edited

Loading

tuliocasagrande commented Jul 11, 2016

thaissiqueira commented Dec 30, 2016

ghost commented Jan 11, 2017

thaissiqueira commented Jan 11, 2017

ghost commented Jan 13, 2017

anikarni commented Jan 13, 2017

anikarni left a comment

anikarni Jan 13, 2017

anikarni Jan 13, 2017

anikarni Jan 13, 2017

anikarni Jan 13, 2017

anikarni Jan 13, 2017

anikarni Jan 13, 2017

		@@ -1,4 +1,4 @@
		Pixelated User Agent Service
		ixelated User Agent Service

Added show raw mail function #739

Are you sure you want to change the base?

Added show raw mail function #739

Conversation

ghost commented Jul 3, 2016

ayoyoness commented Jul 4, 2016

ghost commented Jul 4, 2016

ayoyoness commented Jul 4, 2016 • edited Loading

tuliocasagrande commented Jul 11, 2016

thaissiqueira commented Dec 30, 2016

ghost commented Jan 11, 2017

thaissiqueira commented Jan 11, 2017

ghost commented Jan 13, 2017

anikarni commented Jan 13, 2017

anikarni left a comment

Choose a reason for hiding this comment

anikarni Jan 13, 2017

Choose a reason for hiding this comment

anikarni Jan 13, 2017

Choose a reason for hiding this comment

anikarni Jan 13, 2017

Choose a reason for hiding this comment

anikarni Jan 13, 2017

Choose a reason for hiding this comment

anikarni Jan 13, 2017

Choose a reason for hiding this comment

anikarni Jan 13, 2017

Choose a reason for hiding this comment

ayoyoness commented Jul 4, 2016 •

edited

Loading