Initialize empty toOne relationships actually empty #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObjectProxy
s fortoOne
relationships were initialised with a freshEmber.Object.create()
as their content. Because of this, you can not do this:if (resource.get('some-to-one-relationship')) { ... }
or{{#if resource.some-to-one-relationship}} ... {{/if}}
resource.get('some-to-one-relationship.content')
would not work either. You'd have to go look for attributes:resource.get('some-to-one-relationship.id')
.But that doesn't work either, since there isn't really an attribute that should always be set... Maybe
type
, but that's just a hack.By initialising with something falsy like
null
, we're all good.