Update Columns Being Displayed #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kartik Pattaswamy <[email protected]>
Signed-off-by: Kartik Pattaswamy <[email protected]>
Signed-off-by: Kartik Pattaswamy <[email protected]>
NickLanam
approved these changes
Jul 13, 2022
| type Props = QueryEditorProps<DataSource, PixieDataQuery, PixieDataSourceOptions>; | ||
|
|
||
| export function getColumnsScript( | ||
| chosenOptions: Array<SelectableValue<number>>, |
There was a problem hiding this comment.
Nit for a future diff: Array<SelectableValue<number>> shows up so often in this plugin now that maybe we should alias it in types.ts, like export type SelectableColumns = Array<SelectableValue<number>> or some other useful name.
…o display cols Signed-off-by: Kartik Pattaswamy <[email protected]>
NickLanam
approved these changes
Jul 13, 2022
aimichelle
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR presets all column options as chosen to display when a script is selected. Removing a particular column that is being displayed will safely remove that column's usage in a potential groupby/aggregate query as well.
Also renamed the column_filtering.tsx file to column_display.tsx for better representation and moved corresponding functionality to that file from query_editor.tsx.