Add __requires field to dashboard json files.
#88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hannah Troisi <[email protected]>
nserrino
reviewed
Sep 13, 2022
Signed-off-by: Hannah Troisi <[email protected]>
htroisi
commented
Sep 15, 2022
| @@ -735,7 +755,8 @@ | |||
| }, | |||
| "timepicker": {}, | |||
| "timezone": "", | |||
| "title": "px/cluster", | |||
| "title": "Pixie K8s Cluster Overview", | |||
There was a problem hiding this comment.
I changed the title of these dashboards so that they are more understandable to users who are browsing through Grafana's public dashboard marketplace and may not be familiar with Pixie's live view naming.
nserrino
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to make Pixie's dashboards publicly available on Grafana's dashboard marketplace. The "__requires" field is required otherwise the upload fails:
Signed-off-by: Hannah Troisi [email protected]