Skip to content

Commit

Permalink
[perf_tool] Add templates for datastudio charts and queries. (#1671)
Browse files Browse the repository at this point in the history
Summary: Adds the templates used to create the datastudio visualizations
for the perf_tool.

Type of change: /kind cleanup

Test Plan: N/A (no effect on relevant code, just checked in to make it
easier to change the datastudio visualizations in the future).

Signed-off-by: James Bartlett <[email protected]>
  • Loading branch information
JamesMBartlett authored Aug 14, 2023
1 parent 1a95c5f commit 26cf20e
Show file tree
Hide file tree
Showing 13 changed files with 1,837 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/e2e_test/perf_tool/cmd/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ load("@io_bazel_rules_go//go:def.bzl", "go_library")
go_library(
name = "cmd",
srcs = [
"datastudio.go",
"github_matrix.go",
"root.go",
"run.go",
Expand All @@ -27,6 +28,7 @@ go_library(
importpath = "px.dev/pixie/src/e2e_test/perf_tool/cmd",
visibility = ["//visibility:public"],
deps = [
"//src/e2e_test/perf_tool/datastudio",
"//src/e2e_test/perf_tool/experimentpb:experiment_pl_go_proto",
"//src/e2e_test/perf_tool/pkg/cluster",
"//src/e2e_test/perf_tool/pkg/cluster/gke",
Expand Down
61 changes: 61 additions & 0 deletions src/e2e_test/perf_tool/cmd/datastudio.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
/*
* Copyright 2018- The Pixie Authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
* SPDX-License-Identifier: Apache-2.0
*/

package cmd

import (
log "github.com/sirupsen/logrus"
"github.com/spf13/cobra"
"github.com/spf13/viper"

"px.dev/pixie/src/e2e_test/perf_tool/datastudio"
)

// GenerateDatastudioCmd generates the queries and charts to use in datastudio.
var GenerateDatastudioCmd = &cobra.Command{
Use: "generate_datastudio",
Short: "Generate the sql queries and vega charts to use in datastudio.",
PreRun: func(cmd *cobra.Command, args []string) {
viper.BindPFlags(cmd.Flags())
},
Run: func(cmd *cobra.Command, args []string) {
generateDatastudioCmd(cmd)
},
}

func init() {
GenerateDatastudioCmd.Flags().StringP("output", "o", "", "Path to put generated queries and charts")
GenerateDatastudioCmd.Flags().String("bq_project", "", "Gcloud project containing bq dataset to query from.")
GenerateDatastudioCmd.Flags().String("bq_dataset", "", "BQ dataset to query from.")
GenerateDatastudioCmd.Flags().String("ds_report_id", "", "The unique ID of the datastudio report, used for self-links in the datastudio charts")
GenerateDatastudioCmd.Flags().String("ds_experiment_page_id", "", "The unique ID of the datastudio experiment page, used for self-links in the datastudio charts")

RootCmd.AddCommand(GenerateDatastudioCmd)
}

func generateDatastudioCmd(*cobra.Command) {
outPath := viper.GetString("output")
project := viper.GetString("bq_project")
datasetName := viper.GetString("bq_dataset")
reportID := viper.GetString("ds_report_id")
experimentPageID := viper.GetString("ds_experiment_page_id")

if err := datastudio.GenerateViews(outPath, project, datasetName, reportID, experimentPageID); err != nil {
log.WithError(err).Fatal("failed to generate views")
}
}
36 changes: 36 additions & 0 deletions src/e2e_test/perf_tool/datastudio/BUILD.bazel
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# Copyright 2018- The Pixie Authors.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#
# SPDX-License-Identifier: Apache-2.0

load("@io_bazel_rules_go//go:def.bzl", "go_library")

go_library(
name = "datastudio",
srcs = ["datastudio.go"],
embedsrcs = [
"templates/charts/experiment/bytes.json",
"templates/charts/experiment/percent.json",
"templates/charts/suite/bytes.json",
"templates/charts/suite/percent.json",
"templates/queries/all_suites_workloads_parameters.sql",
"templates/queries/experiment_view.sql",
"templates/queries/suite_view.sql",
"templates/queries/cpu_usage_preprocessing.sql",
"templates/queries/suite_view_app_overhead.sql",
],
importpath = "px.dev/pixie/src/e2e_test/perf_tool/datastudio",
visibility = ["//visibility:public"],
deps = ["@com_github_masterminds_sprig_v3//:sprig"],
)
Loading

0 comments on commit 26cf20e

Please sign in to comment.