Skip to content

Commit

Permalink
Don't fail GH action on empty XML test results (#1772)
Browse files Browse the repository at this point in the history
Summary: Our build and test avoidance sometimes runs no tests. This
is fine and we shouldn't fail the XML reporter in this scenario.

Relevant Issues: N/A

Type of change: /kind infra

Test Plan: Check the test reporter on a PR that triggers no tests.

Signed-off-by: Vihang Mehta <[email protected]>
  • Loading branch information
vihangm authored Nov 29, 2023
1 parent dffdb3b commit 3fbdf5f
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/build_and_test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -170,10 +170,11 @@ jobs:
if: always()
with:
name: testlogs-${{ matrix.name }} tests
path: 'bazel-testlogs/**/*.xml'
path: 'bazel-testlogs/**/test.xml'
reporter: java-junit
list-suites: all
list-tests: failed
fail-on-empty: false
- name: Buildbuddy URL
if: always()
run: |
Expand Down

0 comments on commit 3fbdf5f

Please sign in to comment.