Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert change that causes
px deploy
to timeout on initial deployment (
#1899) Summary: Revert change that causes `px deploy` to timeout on initial deployment This reverts #1670, which creates a circular dependency between the operator and the cloud connector service. The cloud connector service is responsible for [registering a vizier](https://github.com/pixie-io/pixie/blob/fb18345808e6fbd8aed02dac8163469322b84205/src/vizier/services/cloud_connector/bridge/server.go#L290-L302) and populating the `pl-cluster-secrets` k8s secret with its vizier ID. The operator is responsible for creating the vizier services (including the cloud connector), so [this call](https://github.com/pixie-io/pixie/blob/fb18345808e6fbd8aed02dac8163469322b84205/src/operator/controllers/vizier_controller.go#L503) will never succeed on a fresh install. This bug doesn't cause pixie installs to fail completely. A `px deploy` cli command will time out after 10 minutes and then the vizier is deployed following that timeout expiration. While it eventually converges to a healthy vizier, this is a poor user experience. The perf tool is also experiencing this problem, but because it requires `px deploy` to return a successful status code it is causing it to fail completely. Relevant Issues: Reopens #1632 Type of change: /kind bug Test Plan: Reverted this change and verified that the a `skaffold`'ed operator doesn't timeout Signed-off-by: Dom Del Nano <[email protected]>
- Loading branch information