Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Skip k8s resources that have an empty name during resource deletion (#…
…2032) Summary: Skip k8s resources that have an empty name during resource deletion Newer versions of k8s break our `px delete` cli logic (see details on #2029). I tracked this down to the the [condition function](https://github.com/kubernetes/kubectl/blob/0315be426ca25e6554f1c9089534b62ce12254d4/pkg/cmd/wait/delete.go#L41-L43) in our ObjectDeleter. I believe the newer versions of k8s added resources that match our visitor, but don't have a resource name. From my testing, it seemed related to the `ValidatingAdmissionPolicies` or `ValidatingAdmissionPolicyBindings` resources. Relevant Issues: Closes #2029 Type of change: /kind bugfix Test Plan: Deployed a vizier and verified that a subsequent `px delete` deleted the following * `pl` namespace * `px-operator` namespace * Cluster scoped resources: `pl-cloud-connector-role`, `pl-vizier-metadata` and `pl-node-view` cluster roles Changelog Message: Fixed an issue that caused `px delete` to fail on newer k8s clusters (1.30 and later) Signed-off-by: Dom Del Nano <[email protected]>
- Loading branch information