Skip to content

Commit

Permalink
Unify curl image usage to use curl 7.87.0 multiarch image (#1934)
Browse files Browse the repository at this point in the history
Summary: Unify curl image usage to use curl 7.87.0 multiarch image

Relevant Issues: N/A

Type of change: /kind cleanup

Test Plan: Verified the following:
- [x] Successful trace bpf test runs validate noop for test usage
- [x] Verified that the upstream curlimages/curl:7.87.0 is the source of
our ghcr.io image
```
$ docker images
REPOSITORY                                                                       TAG       IMAGE ID       CREATED         SIZE
bazel/image                                                                      image     3148ec916ea7   17 months ago   15MB
curlimages/curl                                                                  7.87.0    3148ec916ea7   17 months ago   15MB
gcr.io/pixie-oss/pixie-dev-public/curl                                           <none>    3148ec916ea7   17 months ago   15MB
ghcr.io/pixie-io/pixie-oss-pixie-dev-public-curl                                 <none>    3148ec916ea7   17 months ago   15MB
```

---------

Signed-off-by: Dom Del Nano <[email protected]>
  • Loading branch information
ddelnano authored May 30, 2024
1 parent 9e4340f commit c7e77e2
Show file tree
Hide file tree
Showing 15 changed files with 19 additions and 18 deletions.
7 changes: 4 additions & 3 deletions bazel/container_images.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -159,11 +159,12 @@ def stirling_test_images():
)

# Curl container, for OpenSSL tracing tests.
# curlimages/curl:7.74.0
# curlimages/curl:7.87.0
# multiarch sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
_container_image(
name = "curl_base_image",
repository = "curlimages/curl",
digest = "sha256:5594e102d5da87f8a3a6b16e5e9b0e40292b5404c12f9b6962fd6b056d2a4f82",
repository = "pixie-oss-pixie-dev-public-curl",
digest = "sha256:4311823d3576c0b7330beccbe09896ff0378c9c1c6f6974ff9064af803fed766",
)

# Ruby container, for OpenSSL tracing tests.
Expand Down
2 changes: 1 addition & 1 deletion demos/sock-shop/sock-shop-loadgen.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ spec:

initContainers:
- name: wait-sock-shop
image: ghcr.io/pixie-io/px-sock-shop-curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
image: ghcr.io/pixie-io/pixie-oss-pixie-dev-public-curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
command: ['sh', '-c', 'set -x;
until timeout 2 curl -f "${SOCK_SHOP_HEALTH_ADDR}"; do
echo "waiting for ${SOCK_SHOP_HEALTH_ADDR}";
Expand Down
2 changes: 1 addition & 1 deletion k8s/cloud/base/ory_auth/kratos/kratos_deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ spec:
- name: admin-create-if-not-exists
imagePullPolicy: IfNotPresent
# yamllint disable-line rule:line-length
image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
image: ghcr.io/pixie-io/pixie-oss-pixie-dev-public-curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
command: ['sh', '-c', 'set -x;
URL="${ADMIN_URL}/admin/health/ready";
until [ $(curl -k -m 0.5 -s -o /dev/null -w "%{http_code}" ${URL}) -eq 200 ]; do
Expand Down
2 changes: 1 addition & 1 deletion k8s/devinfra/buildbuddy-executor/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ config:
extraInitContainers:
- name: download-executor
# yamllint disable-line rule:line-length
image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
image: ghcr.io/pixie-io/pixie-oss-pixie-dev-public-curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
# yamllint disable rule:line-length
command: ['sh', '-c', 'set -e;
curl -fsSL https://github.com/buildbuddy-io/buildbuddy/releases/download/v2.12.42/executor-enterprise-linux-amd64 > /bb-executor/executor;
Expand Down
2 changes: 1 addition & 1 deletion k8s/vizier/base/kelvin_deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ spec:
initContainers:
- name: qb-wait
# yamllint disable-line rule:line-length
image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
image: ghcr.io/pixie-io/pixie-oss-pixie-dev-public-curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
command: ['sh', '-c', 'set -x;
URL="https://${SERVICE_NAME}:${SERVICE_PORT}/healthz";
until [ $(curl -m 0.5 -s -o /dev/null -w "%{http_code}" -k ${URL}) -eq 200 ]; do
Expand Down
2 changes: 1 addition & 1 deletion k8s/vizier/base/patch_sentry.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ spec:
initContainers:
- name: cc-wait
# yamllint disable-line rule:line-length
image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
image: ghcr.io/pixie-io/pixie-oss-pixie-dev-public-curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
command: ['sh', '-c', 'set -x;
URL="https://${SERVICE_NAME}:${SERVICE_PORT}/readyz";
until [ $(curl -m 0.5 -s -o /dev/null -w "%{http_code}" -k ${URL}) -eq 200 ]; do
Expand Down
2 changes: 1 addition & 1 deletion k8s/vizier/base/query_broker_deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ spec:
initContainers:
- name: mds-wait
# yamllint disable-line rule:line-length
image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
image: ghcr.io/pixie-io/pixie-oss-pixie-dev-public-curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
command: ['sh', '-c', 'set -x;
URL="https://${SERVICE_NAME}:${SERVICE_PORT}/healthz";
until [ $(curl -m 0.5 -s -o /dev/null -w "%{http_code}" -k ${URL}) -eq 200 ]; do
Expand Down
2 changes: 1 addition & 1 deletion k8s/vizier/bootstrap/cloud_connector_deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ spec:
initContainers:
- name: nats-wait
# yamllint disable-line rule:line-length
image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
image: ghcr.io/pixie-io/pixie-oss-pixie-dev-public-curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
command: ['sh', '-c', 'set -xe;
URL="${PROTOCOL}://${SERVICE_NAME}:${SERVICE_PORT}${HEALTH_PATH}";
until [ $(curl -m 0.5 -s -o /dev/null -w "%{http_code}" -k ${URL}) -eq 200 ]; do
Expand Down
4 changes: 2 additions & 2 deletions k8s/vizier/etcd_metadata/base/metadata_deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ spec:
initContainers:
- name: nats-wait
# yamllint disable-line rule:line-length
image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
image: ghcr.io/pixie-io/pixie-oss-pixie-dev-public-curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
command: ['sh', '-c', 'set -xe;
URL="${PROTOCOL}://${SERVICE_NAME}:${SERVICE_PORT}${HEALTH_PATH}";
until [ $(curl -m 0.5 -s -o /dev/null -w "%{http_code}" -k ${URL}) -eq 200 ]; do
Expand All @@ -57,7 +57,7 @@ spec:
value: "http"
- name: etcd-wait
# yamllint disable-line rule:line-length
image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
image: ghcr.io/pixie-io/pixie-oss-pixie-dev-public-curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
# yamllint disable rule:line-length
command: ['sh', '-c', 'set -xe;
ETCD_PATH="${PL_MD_ETCD_SERVER}";
Expand Down
2 changes: 1 addition & 1 deletion k8s/vizier/pem/base/pem_daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ spec:
initContainers:
- name: qb-wait
# yamllint disable-line rule:line-length
image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
image: ghcr.io/pixie-io/pixie-oss-pixie-dev-public-curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
command: ['sh', '-c', 'set -x;
URL="https://${SERVICE_NAME}:${SERVICE_PORT}/healthz";
until [ $(curl -m 0.5 -s -o /dev/null -w "%{http_code}" -k ${URL}) -eq 200 ]; do
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ spec:
initContainers:
- name: nats-wait
# yamllint disable-line rule:line-length
image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
image: ghcr.io/pixie-io/pixie-oss-pixie-dev-public-curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
command: ['sh', '-c', 'set -xe;
URL="${PROTOCOL}://${SERVICE_NAME}:${SERVICE_PORT}${HEALTH_PATH}";
until [ $(curl -m 0.5 -s -o /dev/null -w "%{http_code}" -k ${URL}) -eq 200 ]; do
Expand Down
2 changes: 1 addition & 1 deletion k8s/vizier/sanitizer/kelvin_deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ spec:
initContainers:
- name: qb-wait
# yamllint disable-line rule:line-length
image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
image: ghcr.io/pixie-io/pixie-oss-pixie-dev-public-curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
command: ['sh', '-c', 'set -x;
URL="https://${SERVICE_NAME}:${SERVICE_PORT}/healthz";
until [ $(curl -m 0.5 -s -o /dev/null -w "%{http_code}" -k ${URL}) -eq 200 ]; do
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ spec:
initContainers:
- name: wait-for-publisher
# yamllint disable-line rule:line-length
image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
image: ghcr.io/pixie-io/pixie-oss-pixie-dev-public-curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
# yamllint disable rule:line-length
command: ['sh', '-c', 'set -xe;
URL="http://jetstream-publisher.${NS}.svc.cluster.local:8080/metrics";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ spec:
initContainers:
- name: server-wait
# yamllint disable-line rule:line-length
image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
image: ghcr.io/pixie-io/pixie-oss-pixie-dev-public-curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
# yamllint disable rule:line-length
command: ['sh', '-c', 'set -xe;
URL="${PROTOCOL}://${SERVICE_NAME}:${SERVICE_PORT}${HEALTH_PATH}";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ spec:
initContainers:
- name: server-wait
# yamllint disable-line rule:line-length
image: gcr.io/pixie-oss/pixie-dev-public/curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
image: ghcr.io/pixie-io/pixie-oss-pixie-dev-public-curl:multiarch-7.87.0@sha256:f7f265d5c64eb4463a43a99b6bf773f9e61a50aaa7cefaf564f43e42549a01dd
# yamllint disable rule:line-length
command: ['sh', '-c', 'set -xe;
URL="http://${SERVICE_NAME}:${SERVICE_PORT}/";
Expand Down

0 comments on commit c7e77e2

Please sign in to comment.