Restore cli default cloud and allow opting into interactive selection #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dom Del Nano <[email protected]>
aimichelle
approved these changes
Aug 26, 2024
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
…pixie-io#1991) Summary: Restore cli default cloud and allow opting into interactive selection We've received feedback from users that is confusing to no longer have a default cloud for the pixie cli. This change restores the previous behavior and picks the alphabetically first option as the default (per [CNCF requirements](https://github.com/cncf/foundation/blob/42bc2197cce2f58b31eae5f5067f0fd04ab73482/website-guidelines.md)). Users can pick from the available clouds through the new `--interactive_cloud_select` flag. Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Verified the following scenarios - [x] `px get viziers` uses default cloud - [x] `px get --interactive_cloud_select viziers` lists the available clouds and uses the selected valueq ``` $ ./px --interactive_cloud_select get viziers Pixie CLI ✔ withpixie.ai:443 Failed to authenticate. Please retry `px auth login`. ``` Signed-off-by: Dom Del Nano <[email protected]> GitOrigin-RevId: 33f0daf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Restore cli default cloud and allow opting into interactive selection
We've received feedback from users that is confusing to no longer have a default cloud for the pixie cli. This change restores the previous behavior and picks the alphabetically first option as the default (per CNCF requirements). Users can pick from the available clouds through the new
--interactive_cloud_selectflag.Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: Verified the following scenarios
px get viziersuses default cloudpx get --interactive_cloud_select vizierslists the available clouds and uses the selected valueq