Fix self hosted cloud image pull error for plugin db updater Job #2026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dom Del Nano <[email protected]>
ddelnano
commented
Sep 18, 2024
Comment on lines
+49
to
+50
| - name: cloud-plugin-load_db | ||
| newName: gcr.io/pixie-oss/pixie-prod/cloud-plugin-load_db |
There was a problem hiding this comment.
This reference image name and the gcr.io one didn't match the Job's manifest
ddelnano@dev-vm:~/code/pixie (ddelnano/fix-plugin-load-db-kustomization-config) $ git grep 'cloud-plugin-load_db'
k8s/cloud/dev/plugin_db_updater_job.yaml: image: cloud-plugin-load_db:latest
k8s/cloud/overlays/plugin_job/plugin_job.yaml: image: cloud-plugin-load_db:latest
vihangm
approved these changes
Sep 18, 2024
ddelnano
deleted the
ddelnano/fix-plugin-load-db-kustomization-config
branch
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
…ie-io#2026) Summary: Fix self hosted cloud image pull error for plugin db updater Job During the 0.1.8 cloud prerelease testing, I noticed that the plugin db updater Job hits an image pull error. This was something that was also reported in the Community slack for the latest release (0.1.7). Relevant Issues: N/A Type of change: /kind bugfix Test Plan: The Job is successfully created without any additional manifest edits Changelog Message: Fixed an issue where the self-hosted cloud install hit an image pull error for the plugin db updater Job Signed-off-by: Dom Del Nano <[email protected]> GitOrigin-RevId: 777c3f9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix self hosted cloud image pull error for plugin db updater Job
During the 0.1.8 cloud prerelease testing, I noticed that the plugin db updater Job hits an image pull error. This was something that was also reported in the Community slack for the latest release (0.1.7).
Relevant Issues: N/A
Type of change: /kind bugfix
Test Plan: The Job is successfully created without any additional manifest edits
Changelog Message: Fixed an issue where the self-hosted cloud install hit an image pull error for the plugin db updater Job