Add option to set RX telephone-event PT #3705
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To implement the proposal by @nanangizz as described in #3661:
Allow app overriding
si->rx_event_pt
via PJSUA callbackon_stream_precreate()
(and PJSUA2). This can be useful for cases such as:To avoid multiple PTs offered, it is recommended to disable
PJMEDIA_TELEPHONE_EVENT_ALL_CLOCKRATES
. Then application can simply overrideparam->stream_info.info.aud.rx_event_pt
toPJMEDIA_RTP_PT_TELEPHONE_EVENTS
or the PT expected to be sent by remote.To fix #3700 as well.
Tested here and it seems to work as expected:
Before patch (if remote sends DTMF PT different than the SDP):
After patch: