-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add socket option params to transport config in PJSUA2 #4071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the lifetime requirement is because the setting is shallow-cloned by transport listener (to be applied to transport instances), perhaps change it to deep-clone to avoid the lifetime requirement? This sounds more like a PJSIP transport issue though. |
nanangizz
reviewed
Sep 12, 2024
nanangizz
approved these changes
Sep 13, 2024
trengginas
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing #3424.
There are a couple of complications with socket options in PJSUA2 level:
So instead, adopting a similar approach as Android API:
https://developer.android.com/reference/android/system/Os#setsockoptInt(java.io.FileDescriptor,%20int,%20int,%20int)
here we pass the option value by setting the integer value. Currently, only integer option value is supported, but this can be extensible to other types, such as timeval.
In addition, we also add API
pj_sockopt_params_clone()
to perform deep clone of the socket options, so app doesn't need to maintain the buffer.