Fix UPnP IGD search and port mapping deletion #4094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is reported that freeing the XML document returned by
UpnpActionComplete_get_ActionResult()
will cause crash.Note that I am unable to reproduce the issue on my Mac (even under Address Sanitizer), but according to the sample:
https://github.com/pupnp/pupnp/blob/branch-1.14.x/upnp/sample/common/sample_util.c#L447
it seems to be unnecessary to call
ixmlDocument_free()
.Another fix in this PR is to remove the version matching for the IGD.
In my newest router device, it broadcasts that it uses version 2:
urn:schemas-upnp-org:device:InternetGatewayDevice:2
.