Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc fix (Coverity and build warning) #4146

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Misc fix (Coverity and build warning) #4146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c582f1
Fixed Coverity warning of uninit algoType
sauwming Nov 12, 2024
31259ad
Fixed warning of unused functions
sauwming Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion pjlib/src/pj/ssl_sock_apple.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -576,7 +576,7 @@ static pj_status_t create_identity_from_cert(applessl_sock_t *assock,
identity = (SecIdentityRef)
CFDictionaryGetValue((CFDictionaryRef) item,
kSecImportItemIdentity);
identity = CFRetain(identity);
CFRetain(identity);
break;
}
#if !TARGET_OS_IPHONE
Expand Down Expand Up @@ -1416,6 +1416,11 @@ static pj_status_t ssl_create(pj_ssl_sock_t *ssock)
* is started.
*/
PJ_UNUSED_ARG(ssock);

/* Suppress warnings */
PJ_UNUSED_ARG(circ_reset);
PJ_UNUSED_ARG(circ_read_cancel);

return PJ_SUCCESS;
}

Expand Down
6 changes: 4 additions & 2 deletions pjsip/src/pjsua2/siptypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,8 @@ void writeSipHeaders(ContainerNode &node,
///////////////////////////////////////////////////////////////////////////////

AuthCredInfo::AuthCredInfo()
: scheme("digest"), realm("*"), dataType(0)
: scheme("digest"), realm("*"), dataType(0),
algoType(PJSIP_AUTH_ALGORITHM_NOT_SET)
{
}

Expand All @@ -112,7 +113,8 @@ AuthCredInfo::AuthCredInfo(const string &param_scheme,
const int param_data_type,
const string param_data)
: scheme(param_scheme), realm(param_realm), username(param_user_name),
dataType(param_data_type), data(param_data)
dataType(param_data_type), data(param_data),
algoType(PJSIP_AUTH_ALGORITHM_NOT_SET)
{
}

Expand Down
Loading