fix timestamp and duration for received dtmf events for G722 and Opus (#4117) #4159
+17
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauwming
reviewed
Nov 14, 2024
pjmedia/src/pjmedia/stream.c
Outdated
| @@ -1841,10 +1855,23 @@ static void handle_incoming_dtmf( pjmedia_stream *stream, | |||
| * the DTMF digits in the buffer. | |||
| */ | |||
| if (stream->dtmf_event_cb) { | |||
| /* Correct duration and timestamp for codecs where clock_rate | |||
There was a problem hiding this comment.
since this is essentially the same code as above, should we put it in the outer block instead, to avoid duplication?
There was a problem hiding this comment.
yes, i agree. I've added a commit to reduce redundancy: 65f91a8
sauwming
approved these changes
Nov 15, 2024
pjmedia/src/pjmedia/stream.c
Outdated
| /* Correct duration and timestamp for codecs where clock_rate | ||
| * differs from sample rate | ||
| */ | ||
| float ts_modifier = 1.0; |
There was a problem hiding this comment.
Thank you. Only one small modification required. The variable declaration needs to be at the beginning of the block.
R-Jeske
force-pushed
the
fix_timestamp_and_duration_for_dtmf
branch
from
65f91a8
to
1535801
Compare
nanangizz
approved these changes
Nov 18, 2024
trengginas
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes: #4117: DTMF duration is wrong for G722 on receiver with RFC2833
For G722 and Opus, the sample rate may differ from the clock rate. Thus, the calculation of duration and timestamp of a received RFC2833 DTMF event must be recalculated based on the real clock rate specified as specified in the standards.