Fix set/get locale for error string never work in mingw #4162
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in mingw, autoconf set PJ_WIN32_WINNT/WINVER to 0x0400, but SetThreadLocale/GetThreadLocale need WINVER >= 0x0500
trengginas
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mingw, autoconf set PJ_WIN32_WINNT/WINVER to 0x0400,
but SetThreadLocale/GetThreadLocale need WINVER >= 0x0500
pjproject/pjlib/src/pj/os_error_win32.c
Line 178 in 4aa26a9
pjproject/pjlib/src/pjlib-test/errno.c
Line 89 in 4aa26a9
fixed by set PJ_WIN32_WINNT to 0x0501 (xp)