Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API to register custom SDP comparison callback #4286

Merged
merged 2 commits into from
Feb 6, 2025
Merged

Conversation

sauwming
Copy link
Member

@sauwming sauwming commented Feb 4, 2025

Since SDP can be customized (for example, it can contain custom attributes), app may wish to add its own SDP comparison logic on top of the implementation provided by pjmedia_sdp_session_cmp().

The PR will provide API which allows app to register a custom SDP comparison callback.

@nanangizz
Copy link
Member

While here, pjmedia_sdp_session_cmp() docs may be better to be updated too on which SDP fields it compares.

Btw, perhaps it is good idea to let pjmedia_sdp_session_cmp() invokes the callback too (also, make the callback to be part of sdp_cmp instead of sdp_neg)?

@sauwming sauwming merged commit 2fff775 into master Feb 6, 2025
37 of 41 checks passed
@sauwming sauwming deleted the sdp-cmp branch February 6, 2025 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants