Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed msg_data assertion in pjsua_acc_send_request() API #4298

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Conversation

sauwming
Copy link
Member

@sauwming sauwming commented Feb 6, 2025

According to the doc of pjsua_acc_send_request():

 * @param msg_data      Optional headers etc. to be added to the outgoing
 *                      request, or NULL if no custom header is desired.

But we raise assertion if no msg_data is provided. Furthermore, we use msg_data->target_uri as destination while dest_uri parameter itself is unused.

@sauwming sauwming merged commit 4ded10f into master Feb 7, 2025
42 checks passed
@sauwming sauwming deleted the acc-req branch February 7, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants