Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OldPackageNameDep: check for dependency using pkgmoved name #694

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

arthurzam
Copy link
Member

Results on current master. Important to note that some of them block on it's own previous name (like net-analyzer/snmpclitools). Not sure if this is fine or should be whitelisted.

games-action/descent1-freedata
  OldPackageNameDep: version 1: rdepend: '!games-action/d1x-rebirth' uses old package name which is source of pkgmove, rename into 'games-action/dxx-rebirth'

games-action/descent2-freedata
  OldPackageNameDep: version 1: rdepend: '!games-action/d2x-rebirth' uses old package name which is source of pkgmove, rename into 'games-action/dxx-rebirth'

games-action/dxx-rebirth
  OldPackageNameDep: version 0.61.0_pre20240630: rdepend: '!<games-action/d1x-rebirth-0.59.100' uses old package name which is source of pkgmove, rename into 'games-action/dxx-rebirth'
  OldPackageNameDep: version 0.61.0_pre20240630: rdepend: '!<games-action/d2x-rebirth-0.59.100' uses old package name which is source of pkgmove, rename into 'games-action/dxx-rebirth'
  OldPackageNameDep: version 9999: rdepend: '!<games-action/d1x-rebirth-0.59.100' uses old package name which is source of pkgmove, rename into 'games-action/dxx-rebirth'
  OldPackageNameDep: version 9999: rdepend: '!<games-action/d2x-rebirth-0.59.100' uses old package name which is source of pkgmove, rename into 'games-action/dxx-rebirth'

games-puzzle/world-of-goo-gog
  OldPackageNameDep: version 1.51.29337: rdepend: '!games-puzzle/world-of-goo' uses old package name which is source of pkgmove, rename into 'games-puzzle/world-of-goo-hb'

games-puzzle/world-of-goo-hb
  OldPackageNameDep: version 1.53: rdepend: '!games-puzzle/world-of-goo' uses old package name which is source of pkgmove, rename into 'games-puzzle/world-of-goo-hb'

net-analyzer/snmpclitools
  OldPackageNameDep: version 0.6.4-r1: rdepend: '!dev-python/pysnmp-apps' uses old package name which is source of pkgmove, rename into 'net-analyzer/snmpclitools'

Resolves: #659

@thesamesam
Copy link
Member

Let's include self-blockers as it's either based on a misunderstanding of pkgmoves, might indicate a missing one, or a workaround for an old issue which can be removed eventually (e.g. botched pkgmove).

Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely and elegant!

src/pkgcheck/checks/visibility.py Outdated Show resolved Hide resolved
src/pkgcheck/checks/visibility.py Outdated Show resolved Hide resolved
@gentoo-bot gentoo-bot merged commit dacab55 into pkgcore:master Jul 19, 2024
6 of 7 checks passed
@arthurzam arthurzam deleted the check-OldPackageNameDep branch July 19, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing pkgmove detection for blockers
3 participants