Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mask: support auto filing of last-rite bug & PMASKED bugs #187

Merged
merged 3 commits into from
May 19, 2024

Conversation

arthurzam
Copy link
Member

And my newest hat trick, auto filing of last-rite bugs. I was getting fed up with all the lr-file-bug calls during the EAPI=6 cleanup, passing all the args correctly in the form, and then copying everything back to pkgdev mask invocation. So since I'm that comfortable with filing bugs using pkgdev bugs, why not import it into pkgdev mask?

  1. File a new bug, CC treecleaners, auto assign to all maintainers, add blocks on reference bugs.
  2. Add PMASKED keyword to all referenced bugs.
  3. Continue as usual.

@arthurzam arthurzam requested a review from thesamesam May 17, 2024 14:38
Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 77.02%. Comparing base (95300aa) to head (a4520f8).
Report is 1 commits behind head on main.

Files Patch % Lines
src/pkgdev/scripts/pkgdev_mask.py 55.55% 21 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #187      +/-   ##
==========================================
- Coverage   78.12%   77.02%   -1.10%     
==========================================
  Files          15       15              
  Lines        1417     1454      +37     
  Branches      336      335       -1     
==========================================
+ Hits         1107     1120      +13     
- Misses        282      301      +19     
- Partials       28       33       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@thesamesam thesamesam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful, thank you! I still wonder about mail support...

@arthurzam
Copy link
Member Author

Wonderful, thank you! I still wonder about mail support...

Umm, --email? Already supported I think?

@gentoo-bot gentoo-bot merged commit a4520f8 into pkgcore:main May 19, 2024
6 of 9 checks passed
@arthurzam arthurzam deleted the mask-file-bug branch May 19, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants