Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/tgyuu/#112 #120

Merged
merged 5 commits into from
Feb 6, 2024
Merged

Fix/tgyuu/#112 #120

merged 5 commits into from
Feb 6, 2024

Conversation

tgyuuAn
Copy link
Member

@tgyuuAn tgyuuAn commented Feb 6, 2024

1. ๐Ÿ“„ ๊ด€๋ จ๋œ ์ด์Šˆ ๋ฐ ์†Œ๊ฐœ

closed #112

2. ๐Ÿ”ฅ ๋ณ€๊ฒฝ๋œ ์ 

- ์ด์ œ ๋ฐ”ํ…€ ๋ฐ”๊ฐ€ ์—†๋Š” ํ™”๋ฉด์—์„œ๋„ ํ•˜๋‹จ Navigation Bar์— UI๊ฐ€ ๊ฐ€๋ ค์ง€์ง€ ์•Š์•„์š”!

- WappSubTopBar๊ฐ€ ์‚ฌ์šฉ๋˜๋Š” UI์—์„œ ๋งˆ์ง„์ด ์ œ๊ฐ๊ฐ์ด๋˜๊ฑธ ๋ฐ”๋กœ ์žก์•˜์Šต๋‹ˆ๋‹ค.

3. โœ… ๊ผญ ํ™•์ธํ•ด์คฌ์œผ๋ฉด ํ•˜๋Š” ๋ถ€๋ถ„

4. ๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท(์„ ํƒ)

5. ๐Ÿ’ก์•Œ๊ฒŒ๋œ ํ˜น์€ ๊ถ๊ธˆํ•œ ์‚ฌํ•ญ๋“ค

SystemBar (ํ•˜๋‹จ ๋„ค๋น„๋ฐ” ํ˜น์€ ์ƒ๋‹จ ์„ค์ •๋ฐ”) ์˜ ์ •๋ณด๋ฅผ ์–ป๋Š” ๋ฐฉ๋ฒ•์ด ์—ฌ๋Ÿฌ๊ฐ€์ง€๊ฐ€ ์žˆ์ง€๋งŒ,

 with(density) {
    Resources.getSystem().run {
        getDimensionPixelSize(
            getIdentifier(
                "navigation_bar_height",
                "dimen",
                "android",
            ),
        ).toDp()
    }
}

๋ฅผ ์ด์šฉํ•ด์„œ ์–ป์„ ์ˆ˜๋„ ์žˆ๋‹ค.

"navigation_bar_height"๋ผ๊ณ  ๋˜์–ด์žˆ๋Š” ๋ถ€๋ถ„์„ "status_bar_height" ๋กœ ๊ณ ์น˜๋ฉด ์ƒ๋‹จ ์„ค์ • ๋ฐ” ๋†’์ด๋„ ์–ป์„ ์ˆ˜ ์žˆ์Œ.

์ถœ์ฒ˜ : pknujsp

@tgyuuAn tgyuuAn added ๐ŸŽจ์œ ์•„์ด๐ŸŽจ ํ”ผ๊ทธ๋งˆ, ์—‘์„ธ๋ฉœ, ์ปดํฌ์ฆˆ ์œ ์•„์ด/์œ ์—‘์Šค ์ž‘์—… ๐Ÿงฉํƒœ๊ทœ๐Ÿงฉ ENFP ์•ˆํƒœ๊ทœ 24์„ธ ๐Ÿ”จํ”ฝ์Šค๐Ÿ”จ ๋ฒ„๊ทธ ๋ฐ ์ž ์žฌ์  ๋ฌธ์ œ ํ•ด๊ฒฐ labels Feb 6, 2024
@tgyuuAn tgyuuAn self-assigned this Feb 6, 2024
@tgyuuAn tgyuuAn added the ๐Ÿ”ฅ๋ฆฌ๋ทฐ ๊ธฐ๋‹ค๋ฆฌ๋Š” ์ค‘๐Ÿ”ฅ PR์„ ์˜ฌ๋ฆฌ๊ณ  ์ฝ”๋“œ๋ฆฌ๋ทฐ๋ฅผ ๊ธฐ๋‹ค๋ฆฌ๊ณ  ์žˆ๋Š” ์ƒํƒœ์ž…๋‹ˆ๋‹ค. label Feb 6, 2024
Copy link
Member

@jeongjaino jeongjaino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์บฌ์บฌ ํƒœ๊ทœ์ƒ ํ•ด๊ฒฐ ํ•˜์…จ๋„ค์š” ์บฌ์บฌ

LGTM์ž…๋‹ˆ๋‹ค์ž‡

@@ -51,9 +50,10 @@ class MainActivity : ComponentActivity() {
setContent {
WappTheme {
val navController = rememberNavController()
val density = LocalDensity.current
val navigationBarHeight = getNavigationBarHeight(density)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

โœจโœจ

@jeongjaino jeongjaino added ๐ŸŒŸ๋จธ์ง€ ํ•ด์ฃผ์„ธ์š”๐ŸŒŸ ์ฝ”๋“œ ๋ฆฌ๋ทฐ๊ฐ€ ์™„๋ฃŒ๋œ ๋’ค PR์„ ์˜ฌ๋ฆฐ์‚ฌ๋žŒ์ด Merge๋ฅผ ํ•˜๋ฉด ๋˜๋Š” ๋‹จ๊ณ„์ž…๋‹ˆ๋‹ค. and removed ๐Ÿ”ฅ๋ฆฌ๋ทฐ ๊ธฐ๋‹ค๋ฆฌ๋Š” ์ค‘๐Ÿ”ฅ PR์„ ์˜ฌ๋ฆฌ๊ณ  ์ฝ”๋“œ๋ฆฌ๋ทฐ๋ฅผ ๊ธฐ๋‹ค๋ฆฌ๊ณ  ์žˆ๋Š” ์ƒํƒœ์ž…๋‹ˆ๋‹ค. labels Feb 6, 2024
@tgyuuAn tgyuuAn merged commit 20b026e into develop Feb 6, 2024
1 check passed
@tgyuuAn tgyuuAn deleted the fix/tgyuu/#112 branch February 6, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐ŸŒŸ๋จธ์ง€ ํ•ด์ฃผ์„ธ์š”๐ŸŒŸ ์ฝ”๋“œ ๋ฆฌ๋ทฐ๊ฐ€ ์™„๋ฃŒ๋œ ๋’ค PR์„ ์˜ฌ๋ฆฐ์‚ฌ๋žŒ์ด Merge๋ฅผ ํ•˜๋ฉด ๋˜๋Š” ๋‹จ๊ณ„์ž…๋‹ˆ๋‹ค. ๐ŸŽจ์œ ์•„์ด๐ŸŽจ ํ”ผ๊ทธ๋งˆ, ์—‘์„ธ๋ฉœ, ์ปดํฌ์ฆˆ ์œ ์•„์ด/์œ ์—‘์Šค ์ž‘์—… ๐Ÿ”จํ”ฝ์Šค๐Ÿ”จ ๋ฒ„๊ทธ ๋ฐ ์ž ์žฌ์  ๋ฌธ์ œ ํ•ด๊ฒฐ ๐Ÿงฉํƒœ๊ทœ๐Ÿงฉ ENFP ์•ˆํƒœ๊ทœ 24์„ธ
Projects
None yet
2 participants