Feature/jaino/#35 #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeongjaino
added
πμ§νΈπ
tgyuuAn
reviewed
Oct 20, 2023
Comment on lines
+7
to
+22
| fun Throwable.toSupportingText(): String { | ||
| return when (this) { | ||
| is UnknownHostException -> { | ||
| "λ€νΈμν¬ μ°κ²°μ΄ μννμ§ μμ΅λλ€." | ||
| } | ||
| is FirebaseAuthException -> { | ||
| this.toSupportingText() | ||
| } | ||
| is FirebaseFirestoreException -> { | ||
| this.toSupportingText() | ||
| } | ||
| else -> { | ||
| "μ μ μλ μ€λ₯κ° λ°μνμμ΅λλ€." | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
μ¬κΈ°μ μμΈ μ²λ¦¬λ₯Ό λ°κ³ μμκΎΌμ.
There was a problem hiding this comment.
λΉλΉλΉλΉλΉ
μ¬κΈ°μ μμΈ λ νΌλ°μ€ μμ΄μ©
tgyuuAn
reviewed
Oct 20, 2023
| @@ -1,4 +1,4 @@ | |||
| package com.android.mediproject.core.ui.base | |||
| package com.wap.wapp.core.commmon.base | |||
|
|
|||
| import android.os.Bundle | |||
There was a problem hiding this comment.
νν μ½λ 리뷰 λ κ²μ¬νμ§ λͺ»ν μνμλ μ± μμ΄ μμ΅λλ€ νν
tgyuuAn
approved these changes
Oct 20, 2023
tgyuuAn
added
πλ¨Έμ§ ν΄μ£ΌμΈμπ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. π κ΄λ ¨λ μ΄μ λ° μκ°
#35 common λͺ¨λ 리λ€μ΄λ° + μμΈμ²λ¦¬ ꡬν
2. π₯λ³κ²½λ μ
utils + const + extension λͺ¨μ common module,
μμΈμ²λ¦¬ throwable to string extenstion ꡬννμ¬, μ€λ₯κ° λ°μνμ λ ν΄λΉ μμΈμ λ°λ₯Έ ν μ€νΈ λ ΈμΆ
3. πΈ μ€ν¬λ¦°μ·(μ ν)
4. π‘μκ²λ νΉμ κΆκΈν μ¬νλ€
Firebaseλ κ°κ° μμΈ FirebaseExceptionμ΄ μκ³ , μλ‘ μ²λ¦¬νλ λ°©λ²μ΄ λ€λ₯΄λ€.
FirebaseAuth -> errorCode,
FirebaseFirestore -> code
Scaffold λ μ΄μμμ ν΅ν΄ SnackBar νΈμΆνκΈ°! SnackBar κ·μ€