-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/jaino/#53 #54
Conversation
override suspend fun getManagementCode(code: String): Result<Boolean> { | ||
return managementDataSource.getManagementCode(code) | ||
} | ||
|
||
override suspend fun postSurveyForm(surveyForm: SurveyForm): Result<Unit> { | ||
return managementDataSource.postSurveyForm( | ||
surveyFormRequest = SurveyFormRequest( | ||
userId = surveyForm.userId, | ||
title = surveyForm.title, | ||
content = surveyForm.content, | ||
surveyQuestion = surveyForm.surveyQuestion, | ||
deadline = surveyForm.deadline.format(DateTimeFormatter.ISO_LOCAL_DATE_TIME), | ||
), | ||
eventId = surveyForm.eventId, | ||
) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํน์ ์ฌ๊ธฐ๋ runCatching ์ํ ์ด์ ๊ฐ ์์๊น์ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํจ์๋ฅผ ํธ์ถํ๋ ๋ก์ง ์์ runCatching ์ด์ ,,,,?
์ ๊ธฐ Local DateTime ํฌ๋งทํ ํ๋ ๋ถ๋ถ์์ ์์ธ๊ฐ ๋ฐ์ํ ๊ฒ ๊ฐ์์, ์ฃผ์๋ ๋ง์์ธ๊ฐ์ ??
๋ฐ๋ก ๋ก์ง์ ์ํํ๋๊ฒ ์๋๊ณ , ๋ฐ๋ก ํ๋ผ๋ฏธํฐ๋ฅผ ๋๊ธฐ๋ ๋ถ๋ถ์ด๋ผ ํ์ง๋ ์์์ต๋๋ค.. !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์์ฐ ์ ๋ ์ด ๋ ๊น์ง ์๋ฌด์๊ฐ ์์ด ๋ค ๊ฐ๋ค ๋ฐ์๋๋ฐ
ํ์ ์ธ์ฌ์ดํธ ;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์์ํ๊ณ ๊ฐ๋จํ ์ฝ๋ฉํธ ๋จ๊ฒจ๋ด์๋๋ท
@Composable | ||
internal fun SurveyRegistrationScreen( | ||
registerSurveyForm: () -> Unit, | ||
viewModel: SurveyRegistrationViewModel = hiltViewModel(), | ||
onBackButtonClicked: () -> Unit, | ||
) { | ||
val snackBarHostState = remember { SnackbarHostState() } | ||
val currentRegistrationState = viewModel.currentRegistrationState.collectAsState().value | ||
val eventList = viewModel.eventList.collectAsState().value | ||
val eventSelection = viewModel.surveyEventSelection.collectAsState().value | ||
val title = viewModel.surveyTitle.collectAsState().value | ||
val content = viewModel.surveyContent.collectAsState().value | ||
val question = viewModel.surveyQuestion.collectAsState().value | ||
val questionType = viewModel.surveyQuestionType.collectAsState().value | ||
val totalQuestionSize = viewModel.surveyQuestionList.collectAsState().value.size + 1 | ||
val time = viewModel.surveyTimeDeadline.collectAsState().value | ||
val date = viewModel.surveyDateDeadline.collectAsState().value |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํน์ ์ ๋ฒ PR ์ฝ๋ฉํธ ์ด๋ป๊ฒ ์๊ฐํ์๋์ ?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ํ์ธํ๋๋ฐ,
์ข์ ๊ฒ ๊ฐ์์. ์๋ฌด๋๋ ์ ์ฒด ํ๋ฉด์ ๋ํด ํ๋ฆฌ๋ทฐ๋ฅผ ๋ชป๋ณด๋๊ฒ ์์ฒญ ํฐ๊ฒ ๊ฐ์์
์ฒซ ์๋๋, ๊ทธ๋๋ Fragment์์์ ๊ธฐ๋ฅ์ ์ต์ํํด์, ๋์ค์ Compose 100%๋ก ๋ง์ด๊ทธ๋ ์ด์ ํ๊ธฐ ์ฝ๋๋ก ๊ตฌํํ๊ธฐ ์ํด์ ๊ทธ๋ ๊ฒ ํ๋๋ฐ ,
๋ฐ๋ก ๋๊ธ๋ณด๋๊น ๊ตณ์ด Activity๊ฐ ์๋๋๋ผ๋, ๋ค๋ฅธ ๊ณณ์์ ์์ฑํด ์ ๋ฌํ ์ ์๋ค๊ณ ํ๋ค์ ใทใท
1. ๐ ๊ด๋ จ๋ ์ด์ ๋ฐ ์๊ฐ
#53 ์ค๋ฌธ์กฐ์ฌ ๋ฑ๋ก ๋ก์ง ๋ฐ ๊ฒ์ฆ ๋ก์ง ๊ตฌํ
2. ๐ฅ๋ณ๊ฒฝ๋ ์
4 ํ์ด์ง
์ด๋ฒคํธ ์ค์ ,
์ค๋ฌธ ์ ๋ณด,
์ค๋ฌธ ์ง๋ฌธ,
์ค๋ฌธ ๋ ์ง ๊ฒ์ฆ ๋ก์ง ๊ตฌํ
Firestore์ ์ค๋ฌธ ์กฐ์ฌ ๋ฐ์ดํฐ ์ฝ์ ๊ตฌํ
3. ๐ธ ์คํฌ๋ฆฐ์ท(์ ํ)
4. ๐ก์๊ฒ๋ ํน์ ๊ถ๊ธํ ์ฌํญ๋ค