Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/tgyuu/#61 #62

Merged
merged 26 commits into from
Dec 9, 2023
Merged

Feature/tgyuu/#61 #62

merged 26 commits into from
Dec 9, 2023

Conversation

tgyuuAn
Copy link
Member

@tgyuuAn tgyuuAn commented Dec 5, 2023

1. πŸ“„ κ΄€λ ¨λœ 이슈 및 μ†Œκ°œ

colsed #61

2. πŸ”₯λ³€κ²½λœ 점

  • xml λ‹€ μ—†μ• κ³  compose 100%둜 λ§ˆμ΄κ·Έλ ˆμ΄μ…˜
  • μ§„ν˜Έλ‹˜μ΄ μž‘μ—…ν•˜μ‹  κ³³ ν˜Έμ΄μŠ€νŒ… μ•ˆλœκ³³ , collectAsStateWithLifeCycle() 적용 μ•ˆλœ κ³³ 쑰금 손 λ΄€μŠ΅λ‹ˆλ‹€.

3. πŸ“Έ μŠ€ν¬λ¦°μƒ·(선택)

4. πŸ’‘μ•Œκ²Œλœ ν˜Ήμ€ κΆκΈˆν•œ 사항듀

  • SurveyCheckScreen μ—μ„œ SafeArgs μ“°λŠ” κ±° << 이건 곡뢀 μ’€ λ”ν•˜κ³  μ μš©ν• κ²Œμš” 일단 default κ°’μœΌλ‘œ "" 만 λ“€μ–΄κ°€μš”.

근데 μ œκ°€ Gradle 뭐 μΆ©λŒν•΄μ„œ,

μƒˆλ‘œ git Cloneν•΄μ„œ μž‘μ—…ν•΄μ„œ lint κ°€ 적용이 μ•ˆλ˜μ–΄μžˆμ–΄μš”.

또 AndroidSutdio μ—μ„œ 전체 μ½”λ“œ clean Up 을 λŒλ €μ„œ, lint 꺠진 곳이 많이 μžˆμ„κ±°μ—μš”.

일단 μ‹œκ°„ μ—†μ–΄μ„œ λŒ€μΆ© PR올리고 ν˜Ήμ‹œ μ§„ν˜Έλ‹˜μ΄λ‚˜ λ‚˜μ€‘μ— μ œκ°€ μ‹œκ°„ 또 되면 lint λŒλ €μ•Όκ² μ–΄μš”.

@tgyuuAn
[ADD] #61 : app λͺ¨λ“ˆ domain μ˜μ‘΄μ„± μΆ”κ°€
c524158
@tgyuuAn
feature #61 : WAPPNavHost
ac678a9
@tgyuuAn
feature #61 : TopLevelDestination
407da53
@tgyuuAn
feature #61 : SignInNavigation
84ffd10
@tgyuuAn
feature #61 : SignUpNavigation
3816145
@tgyuuAn
feature #61 : ManagementNavigation
72b1291
@tgyuuAn
feature #61 : NoticeNavigation
f66a7ca
@tgyuuAn
feature #61 : ProfileSettingNavigation
6ac4f62
@tgyuuAn
feature #61 : SplashNavigation
56f145c
@tgyuuAn
feature #61 : SurveyNavigation
8310e91
@tgyuuAn
feature #61 : WAPPNavHost
9d76e8e
@tgyuuAn
feature #61 : TopLevelDestination
efbbbe2
@tgyuuAn
feature #61 : WappBotomBar
c5c32f7
@tgyuuAn
feature #61 : eventRegistration
9760f2c
@tgyuuAn
feature #61 : surveyRegistration
77be599
@tgyuuAn
feature #61 : navHost μ™„μ„±
312b0c3
@tgyuuAn
feature #61 : surveyCheck
0bc5900
@tgyuuAn
refactor #61 : animatedVisbility -> animatedContent
47e743f
@tgyuuAn
[REFACTOR] #61 : xml, databinding, viewbinding 제거
ffa55fc
@tgyuuAn
[FEATURE] #61 : compose Migration μ™„λ£Œ
cef1650
@tgyuuAn tgyuuAn added πŸŽ¨μœ μ•„μ΄πŸŽ¨ ν”Όκ·Έλ§ˆ, μ—‘μ„Έλ©œ, 컴포즈 μœ μ•„μ΄/μœ μ—‘μŠ€ μž‘μ—… πŸ”§λ¦¬νŒ©ν„°λ§πŸ”§ λ¦¬νŒ©ν„°λ§μΌκΉŒμš” λ¦¬νŒ©ν† λ§μΌκΉŒμš”? πŸ§Ήν—ˆλ“œλ ›μΌπŸ§Ή 쒅속성 μΆ”κ°€, κΈ°λŠ₯κ³Ό λ¬΄κ΄€ν•œ μ½”λ“œ μž‘μ„± πŸ§©νƒœκ·œπŸ§© ENFP μ•ˆνƒœκ·œ 24μ„Έ labels Dec 5, 2023
@tgyuuAn tgyuuAn self-assigned this Dec 5, 2023
jeongjaino
jeongjaino approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@jeongjaino jeongjaino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

νƒœκ·œμƒ κ³ μƒλ§Žμ΄ ν•˜μ…¨μ–΄μš” !!

λ“œλ””μ–΄ Compose 100 % μ΄λ£¨μ—ˆλ„€μš” !

저도 아직 Compose Navigation λ‚΄μš©μ„ 잘 λͺ°λΌμ„œ, μ†Œμ†Œν•˜κ²Œ 리뷰 λ‚¨κ²Œ λ΄€μ–΄μš” !

νƒœκ·œμƒ μ‹œν—˜κ³΅λΆ€ μ—΄μ‹¬νžˆν•˜μ‹œκ΅¬, μ΄λ²ˆν•™κΈ°λ„ 마무리 μž˜ν•˜μ‹œκΈΈ λ°”λž„κ²Œμš” ☺☺

app/src/main/java/com/wap/wapp/component/WappBottomBar.kt
onNavigateToDestination: (TopLevelDestination) -> Unit,
bottomBarState: Boolean,
) {
AnimatedContent(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AnminatedContentλŠ” μ–΄λ–€ κΈ°λŠ₯을 ν•˜λŠ” μ»΄ν¬λ„ŒνŠΈμΈκ°€μš” ??

Copy link
Member Author

@tgyuuAn tgyuuAn Dec 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tgyuuAn/BaekyoungE#9 (comment)

Compose 둜 BottomNavigation을 숨기고 보여주고 ν•  λ•Œ,

μ• λ‹ˆλ©”μ΄μ…˜μ„ μ€˜μ„œ μ’€ 더 λΆ€λ“œλŸ½κ²Œ λ§Œλ“€μ–΄μ£ΌλŠ” 효과λ₯Ό ν•©λ‹ˆλ‹€!!

app/src/main/java/com/wap/wapp/navigation/TopLevelDestination.kt Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ˜‹πŸ˜‹πŸ˜‹πŸ˜‹πŸ˜‹

app/src/main/java/com/wap/wapp/navigation/WappNavHost.kt
import com.wap.wapp.feature.survey.navigation.surveyScreen

@Composable
fun WappNavHost(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ˜‹πŸ˜‹πŸ˜‹πŸ˜‹πŸ˜‹πŸ˜‹πŸ˜‹πŸ˜‹

.../management/src/main/java/com/wap/wapp/feature/management/navigation/ManagementNavigation.kt Outdated
fun NavGraphBuilder.managementScreen(
navigateToEventRegistration: () -> Unit,
navigateToSurveyRegistration: () -> Unit,
showToast: (String) -> Unit = {}, //Todo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ν•΄λ‹Ή νŒŒλΌλ―Έν„°λ₯Ό 넣은 μ΄μœ κ°€ κΆκΈˆν•΄μš” !!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    showToast: (String) -> Unit = {}, //Todo

이 λΆ€λΆ„ λ§μ”€ν•˜μ‹œλŠ” κ±ΈκΉŒμš” ??

μ§„ν˜Έλ‹˜μ΄ μž‘μ—…ν•˜μ‹  λΆ€λΆ„ μ€‘μ—μ„œ Toastλ₯Ό λ„μš°λŠ” 뢀뢄이 μžˆμ–΄μ„œ μΆ”κ°€ν–ˆμ–΄μš”.




근데,

Toastλ₯Ό λ„μšΈ λ•Œ contextκ°€ ν•„μš”ν•΄μ„œ λ‹Ήμ—°νžˆ SAAλ‹ˆκΉŒ MainActivityμ—μ„œ λŒμ–΄μ™€μ•Ό κ² λ‹€ μƒκ°ν–ˆλŠ”λ°,

val context = LocalContext.current

둜 λŒμ–΄μ™€μ„œ μ‚¬μš©ν•  수 μžˆλ„€μš”..

https://stackoverflow.com/questions/58743541/how-to-get-context-in-jetpack-compose

μˆ˜μ •ν•΄μ•Ό ν•  것 κ°™μ•„μš”

jeongjaino
jeongjaino approved these changes Dec 9, 2023
View reviewed changes
feature/management/src/main/java/com/wap/wapp/feature/management/check/SurveyCheckScreen.kt
surveyId: String = "",
navigateToManagement: () -> Unit,
) {
val surveyUiState by viewModel.surveyUiState.collectAsStateWithLifecycle()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ’‹μ˜€μ˜€μ˜€μ˜ΏμŠ΅λ‹ˆλ‹€

μ €λ²ˆμ— ν˜Ήμ‹œ collectAsStateWithLifecycle importκ°€ μ•ˆλœλ‹€κ³  ν•˜μ‹œμ§€ μ•Šμ•˜λ‚˜μš” ??

λ”°λ‘œ λ””νŽœλ˜μ‹œλ₯Ό μΆ”κ°€ν•΄μ•Ό μ‚¬μš©ν•  수 μžˆλŠ” μ΅μŠ€ν…μ…˜μΈκ°€μš” ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ§žμŠ΅λ‹ˆλ‹·

compose-lifecycle = "2.6.0-beta01"

compose-lifecycle = { module = "androidx.lifecycle:lifecycle-runtime-compose", version.ref = "compose-lifecycle" }

λ₯Ό μΆ”κ°€ν•΄μ€˜μ•Όμ§€ μ‚¬μš©ν•  수 μžˆλ”λΌκ³ μš”...!

feature/management/src/main/java/com/wap/wapp/feature/management/check/SurveyCheckScreen.kt
onDoneButtonClicked: () -> Unit,
onBackButtonClicked: () -> Unit,
) {
val surveyUiState = viewModel.surveyUiState.collectAsState().value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이뢀뢄은 생각도 λͺ»ν–ˆλ„€μš” γ„·γ„·

@jeongjaino jeongjaino added the πŸŒŸλ¨Έμ§€ ν•΄μ£Όμ„Έμš”πŸŒŸ μ½”λ“œ 리뷰가 μ™„λ£Œλœ λ’€ PR을 μ˜¬λ¦°μ‚¬λžŒμ΄ Mergeλ₯Ό ν•˜λ©΄ λ˜λŠ” λ‹¨κ³„μž…λ‹ˆλ‹€. label Dec 9, 2023
@jeongjaino
Copy link
Member

λ‚˜μ€‘μ— 린트 체크 μˆ˜ν–‰ν•˜μ‹œκ΅¬ γ…Žγ…Ž κΉƒν—™ μ•‘μ…˜ λ‹€μ‹œ 검사 λΆ€νƒλ“œλ €μš© 😎😎😎😎😎😎😎😎

@tgyuuAn tgyuuAn merged commit 787381e into develop Dec 9, 2023
@tgyuuAn tgyuuAn linked an issue Dec 22, 2023 that may be closed by this pull request
[FEATURE]: xml κ±·μ–΄λ‚΄κ³  Compose Navigation λ„μž… #61
Closed
1 task
@tgyuuAn tgyuuAn deleted the feature/tgyuu/#61 branch February 6, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeongjaino jeongjaino jeongjaino approved these changes

Assignees

@tgyuuAn tgyuuAn

Labels
πŸŒŸλ¨Έμ§€ ν•΄μ£Όμ„Έμš”πŸŒŸ μ½”λ“œ 리뷰가 μ™„λ£Œλœ λ’€ PR을 μ˜¬λ¦°μ‚¬λžŒμ΄ Mergeλ₯Ό ν•˜λ©΄ λ˜λŠ” λ‹¨κ³„μž…λ‹ˆλ‹€. πŸŽ¨μœ μ•„μ΄πŸŽ¨ ν”Όκ·Έλ§ˆ, μ—‘μ„Έλ©œ, 컴포즈 μœ μ•„μ΄/μœ μ—‘μŠ€ μž‘μ—… πŸ”§λ¦¬νŒ©ν„°λ§πŸ”§ λ¦¬νŒ©ν„°λ§μΌκΉŒμš” λ¦¬νŒ©ν† λ§μΌκΉŒμš”? πŸ§©νƒœκ·œπŸ§© ENFP μ•ˆνƒœκ·œ 24μ„Έ πŸ§Ήν—ˆλ“œλ ›μΌπŸ§Ή 쒅속성 μΆ”κ°€, κΈ°λŠ₯κ³Ό λ¬΄κ΄€ν•œ μ½”λ“œ μž‘μ„±
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: xml κ±·μ–΄λ‚΄κ³  Compose Navigation λ„μž…
2 participants
@tgyuuAn @jeongjaino