Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/jaino/#6 #8

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Chore/jaino/#6 #8

merged 3 commits into from
Sep 22, 2023

Conversation

jeongjaino
Copy link
Member

1. ๐Ÿ“„ ๊ด€๋ จ๋œ ์ด์Šˆ ๋ฐ ์†Œ๊ฐœ

#6 Firebase ์„ธํŒ… ๋ฐ ๊ตฌ์ถ•

2. ๐Ÿ”ฅ๋ณ€๊ฒฝ๋œ ์ 

Firebase ํ”„๋กœ์ ํŠธ ์ƒ์„ฑ
Google Service json ์ถ”๊ฐ€ ๋ฐ ์‹œํฌ๋ฆฟ ๋“ฑ๋ก ๋ฐ ๊นƒํ—™ ์•ก์…˜ ์ถ”๊ฐ€
Firebase ์ข…์†์„ฑ, ํ”Œ๋Ÿฌ๊ทธ์ธ ์ถ”๊ฐ€

3. ๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท(์„ ํƒ)

4. ๐Ÿ’ก์•Œ๊ฒŒ๋œ ํ˜น์€ ๊ถ๊ธˆํ•œ ์‚ฌํ•ญ๋“ค

์ด์ „๊นŒ์ง€๋Š” ๊ทธ๋ƒฅ google-service ์˜ฌ๋ ธ๋Š”๋ฐ, gitignore ์‚ฌ์šฉํ•ด์„œ, ๋”ฐ๋กœ ์˜ฌ๋ฆฌ์ง€ ์•Š๋„๋ก ๊ตฌ์„ฑํ•˜์˜€์Œ.
๊ทธ๋ฆฌ๊ณ  secrets์— ๋“ฑ๋กํ•ด, github action์—์„œ ๋นŒ๋“œ๋  ์ˆ˜ ์žˆ๋„๋ก ๊ตฌ์„ฑํ•˜์˜€์Œ.

@jeongjaino jeongjaino added ๐Ÿš€์ง„ํ˜ธ๐Ÿš€ ESTP ์ •์ง„ํ˜ธ 23์„ธ ๐Ÿงนํ—ˆ๋“œ๋ ›์ผ๐Ÿงน ์ข…์†์„ฑ ์ถ”๊ฐ€, ๊ธฐ๋Šฅ๊ณผ ๋ฌด๊ด€ํ•œ ์ฝ”๋“œ ์ž‘์„ฑ ๐Ÿ”ฅ๋ฆฌ๋ทฐ ๊ธฐ๋‹ค๋ฆฌ๋Š” ์ค‘๐Ÿ”ฅ PR์„ ์˜ฌ๋ฆฌ๊ณ  ์ฝ”๋“œ๋ฆฌ๋ทฐ๋ฅผ ๊ธฐ๋‹ค๋ฆฌ๊ณ  ์žˆ๋Š” ์ƒํƒœ์ž…๋‹ˆ๋‹ค. and removed ๐Ÿงนํ—ˆ๋“œ๋ ›์ผ๐Ÿงน ์ข…์†์„ฑ ์ถ”๊ฐ€, ๊ธฐ๋Šฅ๊ณผ ๋ฌด๊ด€ํ•œ ์ฝ”๋“œ ์ž‘์„ฑ labels Sep 21, 2023
@tgyuuAn
Copy link
Member

tgyuuAn commented Sep 22, 2023

์ด์ „ PRํ•˜๊ณ  ๋ฐ˜๋ณต๋˜๋Š” base ์ž‘์—…์ธ๋ฐ Firebase ๋ฒ„์ „์ด๋ผ ๋”ฐ๋กœ ์ฝ”๋ฉ˜ํŠธ ์•ˆ๋‚จ๊ฒผ์–ด์š”.

๋„ˆ๋ฌด ์ˆ˜๊ณ ํ•˜์…จ์Šต๋‹ˆ๋‹ค ...!

Copy link
Member

@tgyuuAn tgyuuAn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๐Ÿ˜Š๐Ÿ˜Š๐Ÿ˜Š๐Ÿ‘๐Ÿ‘

@tgyuuAn tgyuuAn added ๐ŸŒŸ๋จธ์ง€ ํ•ด์ฃผ์„ธ์š”๐ŸŒŸ ์ฝ”๋“œ ๋ฆฌ๋ทฐ๊ฐ€ ์™„๋ฃŒ๋œ ๋’ค PR์„ ์˜ฌ๋ฆฐ์‚ฌ๋žŒ์ด Merge๋ฅผ ํ•˜๋ฉด ๋˜๋Š” ๋‹จ๊ณ„์ž…๋‹ˆ๋‹ค. and removed ๐Ÿ”ฅ๋ฆฌ๋ทฐ ๊ธฐ๋‹ค๋ฆฌ๋Š” ์ค‘๐Ÿ”ฅ PR์„ ์˜ฌ๋ฆฌ๊ณ  ์ฝ”๋“œ๋ฆฌ๋ทฐ๋ฅผ ๊ธฐ๋‹ค๋ฆฌ๊ณ  ์žˆ๋Š” ์ƒํƒœ์ž…๋‹ˆ๋‹ค. labels Sep 22, 2023
@jeongjaino jeongjaino merged commit e30d1ed into develop Sep 22, 2023
1 check passed
@jeongjaino jeongjaino self-assigned this Dec 30, 2023
@tgyuuAn tgyuuAn deleted the chore/jaino/#6 branch February 6, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐ŸŒŸ๋จธ์ง€ ํ•ด์ฃผ์„ธ์š”๐ŸŒŸ ์ฝ”๋“œ ๋ฆฌ๋ทฐ๊ฐ€ ์™„๋ฃŒ๋œ ๋’ค PR์„ ์˜ฌ๋ฆฐ์‚ฌ๋žŒ์ด Merge๋ฅผ ํ•˜๋ฉด ๋˜๋Š” ๋‹จ๊ณ„์ž…๋‹ˆ๋‹ค. ๐Ÿš€์ง„ํ˜ธ๐Ÿš€ ESTP ์ •์ง„ํ˜ธ 23์„ธ
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants