This repository has been archived by the owner on Sep 25, 2023. It is now read-only.
Fixed a bug where wrong schedConfs were displayed in the archive tab #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @killertux -- the current behavior is by design, though I see sense in what you're doing with your modification. FYI, we're not likely to make further releases of OCS 2.x, and will invest some time in a "reboot" of the software on our newer software stack. See https://pkp.sfu.ca/2017/03/06/the-future-of-ocs/ for details. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the file SchedConfsHandler.in.php, was called the function getEnabledSchedConfs to get all scheConfs to display at the archive tab. Changed the function to a new one, getPastSchedConfs