Skip to content
This repository has been archived by the owner on Sep 25, 2023. It is now read-only.

Added files for the uk_UA (Ukrainian) locale #39

Closed
wants to merge 1 commit into from

Conversation

vasylOstrovskyi
Copy link

No description provided.

@mtub
Copy link
Member

mtub commented Aug 13, 2018

Thanks, @vasylOstrovskyi - sorry it took so long to look at this. As written here: https://github.com/pkp/ocs/blob/master/README.md, the master branch is not the active branch. Did you copy most of the code from the Ukrainian translation of the ocs-dev-2_3 branch?

Currently, there is no active development of OCS. I can merge this after you've addressed the comments in my review, but if at some point development work on OCS will start again, all translations will need a closer look.

<!DOCTYPE locale SYSTEM "../../lib/pkp/dtd/locale.dtd">

<!--
* ocs2-devel/locale/en_US/admin.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be ocs2-devel/locale/uk_UA/admin.xml

(see also every other file of this pull request)

*
* Localization strings for the uk_UA (Ukrainian) locale.
*
* Translated by Vasyl Ostrovskyi, 2017
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally, we will put translator information into the wiki. It is possible that we will move this information at some point in the future.

* $Id$
-->

<locale name="en_US" full_name = "English">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be <locale name="uk_UA" full_name = "Українська"> (see also all other files)

<!DOCTYPE locale SYSTEM "../../lib/pkp/dtd/locale.dtd">

<!--
* ocs2-devel/locale/en_US/author.xml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above…

*
-->

<locale name="en_US" full_name = "English">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above…

@mtub mtub closed this Sep 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants