Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable upload of DAR file directly #32

Open
ctgraham opened this issue Oct 11, 2019 · 3 comments
Open

Enable upload of DAR file directly #32

ctgraham opened this issue Oct 11, 2019 · 3 comments

Comments

@ctgraham
Copy link
Contributor

Proposed workflow:
Upload of DAR file via the SubmissionsFilesUploadForm is hooked by this plugin and the contents are extracted (if valid).

Specifically:

  • Hook submissionfilesuploadform::execute examines the upload
  • If a 'dar' extension, and if it has at least a "manuscript.xml" and "manifest.xml"
  • Extract the manuscript.xml to create a new submission file
  • Use the manifest.xml to extract new dependent files
  • Replace the submission file from the upload form with the extracted submission file (and dependent files).

Prerequisite: pkp/pkp-lib#5146

@ctgraham
Copy link
Contributor Author

@withanage , do you have any work so far on processing the DAR within PHP code? This was mentioned in the PKP Technical Committee particularly regarding the recent conversations across Texture and Fidus Writer.

ctgraham added a commit to ulsdevteam/texture that referenced this issue Oct 17, 2019
@withanage
Copy link
Member

withanage commented Oct 17, 2019

@ctgraham
Actually, not yet. The only code which is there is on the generation side in the https://github.com/pkp/jatsTemplate
Sorry for delay in replying due to travelling.

@withanage
Copy link
Member

Proposed workflow:
Upload of DAR file via the SubmissionsFilesUploadForm is hooked by this plugin and the contents are extracted (if valid).

Specifically:

  • Hook submissionfilesuploadform::execute examines the upload
  • If a 'dar' extension, and if it has at least a "manuscript.xml" and "manifest.xml"
  • Extract the manuscript.xml to create a new submission file
  • Use the manifest.xml to extract new dependent files
  • Replace the submission file from the upload form with the extracted submission file (and dependent files).
    Prerequisite: Missing hook call for submissionfilesuploadform::execute pkp-lib#5146

@ctgraham
Thanks for the specification.
This is the exact way, I thought this to do.
An addition will be to check the validity of the manifest file and check if the xml file is valid and has at least a jats body. If no header metadata is avaliable or the plugin configuration allows that, we can fill the jats head with ojs metadata.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants