Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title to webpage when editing texture #87

Merged
merged 5 commits into from
Oct 11, 2020
Merged

Conversation

withanage
Copy link
Member

Copy link

@NateWr NateWr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just a few minor changes.

TextureHandler.inc.php Outdated Show resolved Hide resolved
TextureHandler.inc.php Outdated Show resolved Hide resolved
templates/editor.tpl Outdated Show resolved Hide resolved
@NateWr
Copy link

NateWr commented Sep 28, 2020

Do you have permission to merge? If so, I'll leave the merge to you when you're ready.

@withanage
Copy link
Member Author

Thanks for the review Nate again. I learned lots of new stuff from the comments. Yes, I've got the permissions and will merge it, as soon as I've got the other js stuff also together, so I can release the plugin.

@withanage withanage merged commit 43225f1 into pkp:master Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants