Revise safety bounds for npcap libraries #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathaniel-bennett
force-pushed
the
windows-pointer-fixes
branch
6 times, most recently
from
7e20f9b to
d39fc0b
Compare
nathaniel-bennett
force-pushed
the
windows-pointer-fixes
branch
from
d39fc0b to
8daccd4
Compare
nathaniel-bennett
force-pushed
the
windows-pointer-fixes
branch
from
2720835 to
b698f7d
Compare
nathaniel-bennett
force-pushed
the
windows-pointer-fixes
branch
from
b698f7d to
17a7479
Compare
pkts-rs
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npcapwrapper functions are currently designed to pass mutable references; this adheres to safety constraints but makes async runtimes untenable. This PR changes safety boundaries, opting to passNonNull<Adapter>rather than&mut Adapterreferences to wrapper functions, thereby enabling safe parallel operations to be performed (provided thatUnsafeCellis correctly added and underlying libraries are appropriately thread-safe).