Npcap thread-safe read; &self for send/recv #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathaniel-bennett
force-pushed
the
windows-const-sendrecv
branch
6 times, most recently
from
86c3ced to
3e9ec45
Compare
nathaniel-bennett
force-pushed
the
windows-const-sendrecv
branch
from
3e9ec45 to
c52e820
Compare
pkts-rs
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Npcap uses memory-mapped packets for read operations. This PR implements a thread-safe nonblocking algorithm that allows tasks to read distinct packets in the memory-mapped region synchronously. As a side-effect, this enables us to have
send()/recv()operations to operate on&selfrather than&mut self, which will pave the way for async runtime support.