add support for Csv to rama::http similar to Json support we have

[GlenDC]

For the serde-support you can make use of https://docs.rs/csv/latest/csv.

• impl IntoResponse etc, similar to: https://docs.rs/rama-http-types/0.2.0-alpha.6/src/rama_http_types/response/json.rs.html#56
• impl FromRequest etc, similar to: https://docs.rs/rama-http/0.2.0-alpha.6/src/rama_http/service/web/endpoint/extract/body/json.rs.html#38-40

Note, regarding making a response, for the time being ContentType does not have a csv constructor, so instead you'll use a non-typed approach, e.g.:

[(
    CONTENT_TYPE,
    HeaderValue::from_str(mime::TEXT_CSV).unwrap(),
)],
buf.into_inner().freeze(),

[IamTossan]

In https://docs.rs/rama-http-types/0.2.0-alpha.6/src/rama_http_types/response/json.rs.html#26,
we have an example and a bit below, we got: pub struct Json<T>(pub T);
What could be expected for the inner type for the Csv version?

[GlenDC]

Do you wish to pick up this issue @IamTossan , if so I'll gladly assign it to you.

You would add these trait bounds for the locations where you actually serialize to csv, which I think is only IntoResponse impl:

impl<T> IntoResponse for Csv<T>
where
    T: IntoIterator<Item: Serialize>,
{
   // ...
}

As that are also the trait bounds enforced for the serde-supported API of the csv crate.

Best to probably put sufficient documentation (rustdocs) for the Csv type declaration, and also link to external resources such as https://docs.rs/csv/latest/csv/struct.Writer.html#rules as these also explain what is possible and what not. Csv is not as flexible as json so certain data compositions will result in Serialize::Error's. That's okay, and not much to do about that AFAIK, but at the very least we can properly document it, also add a test and doc example.

[IamTossan]

Hi @GlenDC ,
thanks for your answer.
I'd like to be assigned and I'll try my best, thank you.

[GlenDC]

Amazing @IamTossan . Do let me know if you need help or are stuck.
Feel free to open a PR whenever you feel ready, have questions or need guidance.

I'll assign it to you.

[GlenDC]

Closed in #401 by @IamTossan . Thanks for another great contribution @IamTossan ! Take care.