Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rama-http): add csv support #401

Merged

Conversation

IamTossan
Copy link
Contributor

Add csv support to rama-http

related to #394

Copy link
Member

@GlenDC GlenDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start so far. You're pretty much there I think, left you some comments, hopefully that helps you.

rama-http-types/src/response/csv.rs Outdated Show resolved Hide resolved
rama-http-types/src/response/csv.rs Outdated Show resolved Hide resolved
rama-http/src/service/web/endpoint/extract/body/csv.rs Outdated Show resolved Hide resolved
rama-http/src/service/web/endpoint/extract/body/csv.rs Outdated Show resolved Hide resolved
@IamTossan IamTossan marked this pull request as ready for review January 29, 2025 00:11
Copy link
Member

@GlenDC GlenDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job. Thanks!

@GlenDC GlenDC merged commit 8916d9d into plabayo:main Jan 29, 2025
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants