Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More slack notify #50

Merged
merged 29 commits into from
Nov 21, 2023
Merged

More slack notify #50

merged 29 commits into from
Nov 21, 2023

Conversation

Akamig
Copy link
Contributor

@Akamig Akamig commented Nov 21, 2023

No description provided.

@Akamig Akamig added the enhancement New feature or request label Nov 21, 2023
@Akamig Akamig self-assigned this Nov 21, 2023
@Akamig Akamig force-pushed the more-slack-notify-PDX-158 branch from 7cae2d2 to 5325cc9 Compare November 21, 2023 15:11
@Akamig Akamig marked this pull request as ready for review November 21, 2023 15:34
@Akamig Akamig force-pushed the more-slack-notify-PDX-158 branch from c1aa43b to db6cb36 Compare November 21, 2023 15:45
@@ -51,6 +56,13 @@ export class AssetDownstreamObserver
try {
this.debug("Try to burn");
const burnTxId = await this._burner.burn(ev.amount, ev.txId);
this._slackbot.sendMessage(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this._slackbot.sendMessage(
await this._slackbot.sendMessage(

@@ -77,6 +89,13 @@ export class AssetDownstreamObserver
amount,
null,
);
this._slackbot.sendMessage(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this._slackbot.sendMessage(
await this._slackbot.sendMessage(

package.json Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the prisma dependency added?

requests,
memoForMinter,
);
this._slackbot.sendMessage(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this._slackbot.sendMessage(
await this._slackbot.sendMessage(

Comment on lines 78 to 83
this.jobExecutionStore.putJobExec(
txId,
resTxId,
this._minter.getMinterPlanet(),
"MINT",
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
this.jobExecutionStore.putJobExec(
txId,
resTxId,
this._minter.getMinterPlanet(),
"MINT",
);

private readonly _minter: IMinter;
private readonly jobExecutionStore: IJobExecutionStore;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
private readonly jobExecutionStore: IJobExecutionStore;

This PR has 235 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +179 -56
Percentile : 63.5%

Total files changed: 26

Change summary by file extension:
.ts : +176 -56
.graphql : +3 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@moreal moreal merged commit 4d88c75 into main Nov 21, 2023
@moreal moreal deleted the more-slack-notify-PDX-158 branch November 21, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Large
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants