-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More slack notify #50
Conversation
7cae2d2
to
5325cc9
Compare
c1aa43b
to
db6cb36
Compare
@@ -51,6 +56,13 @@ export class AssetDownstreamObserver | |||
try { | |||
this.debug("Try to burn"); | |||
const burnTxId = await this._burner.burn(ev.amount, ev.txId); | |||
this._slackbot.sendMessage( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this._slackbot.sendMessage( | |
await this._slackbot.sendMessage( |
@@ -77,6 +89,13 @@ export class AssetDownstreamObserver | |||
amount, | |||
null, | |||
); | |||
this._slackbot.sendMessage( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this._slackbot.sendMessage( | |
await this._slackbot.sendMessage( |
package.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the prisma
dependency added?
src/observers/garage-observer.ts
Outdated
requests, | ||
memoForMinter, | ||
); | ||
this._slackbot.sendMessage( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this._slackbot.sendMessage( | |
await this._slackbot.sendMessage( |
src/observers/garage-observer.ts
Outdated
this.jobExecutionStore.putJobExec( | ||
txId, | ||
resTxId, | ||
this._minter.getMinterPlanet(), | ||
"MINT", | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this.jobExecutionStore.putJobExec( | |
txId, | |
resTxId, | |
this._minter.getMinterPlanet(), | |
"MINT", | |
); |
src/observers/garage-observer.ts
Outdated
private readonly _minter: IMinter; | ||
private readonly jobExecutionStore: IJobExecutionStore; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private readonly jobExecutionStore: IJobExecutionStore; |
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
No description provided.