Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ActivateCollection model #615

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

ipdae
Copy link
Member

@ipdae ipdae commented Feb 14, 2024

resolve #614

  • Bump headless feature/collection(base on development)
  • Add ActivateCollection model
  • Add CollectionOption model
+--------------------------------------------+--------------------------------------------+------+-------------+---------+---------+------+----------------------------+
| Address                                    | AgentAddress                               | Name | AvatarLevel | TitleId | ArmorId | Cp   | Timestamp                  |
+--------------------------------------------+--------------------------------------------+------+-------------+---------+---------+------+----------------------------+
| 0x3B5e43BCD802aE0Eb3d596AC06e3eE50690B3002 | 0x3B5e43BCD802aE0Eb3d596AC06e3eE50690B3002 | name |           1 |    NULL |    NULL |    0 | 2024-02-14 13:14:20.475751 |
+--------------------------------------------+--------------------------------------------+------+-------------+---------+---------+------+----------------------------+
1 row in set (0.01 sec)

mysql> select * from ActivateCollections;
+----+--------------------------------------------+--------------+--------------------------------------+------------+----------------------------+
| Id | AvatarAddress                              | CollectionId | ActionId                             | BlockIndex | CreatedAt                  |
+----+--------------------------------------------+--------------+--------------------------------------+------------+----------------------------+
|  1 | 0x3B5e43BCD802aE0Eb3d596AC06e3eE50690B3002 |            1 | 60eead9f-cfc6-4951-8ad6-66af168d2b43 |          1 | 2024-02-14 22:14:20.817663 |
|  2 | 0x3B5e43BCD802aE0Eb3d596AC06e3eE50690B3002 |            2 | 60eead9f-cfc6-4951-8ad6-66af168d2b43 |          2 | 2024-02-14 22:14:20.842378 |
+----+--------------------------------------------+--------------+--------------------------------------+------------+----------------------------+
2 rows in set (0.00 sec)

mysql> select * from CollectionOptionModel;
+----+----------+---------------+-------+----------------------+
| Id | StatType | OperationType | Value | ActivateCollectionId |
+----+----------+---------------+-------+----------------------+
|  1 | HP       | Add           |     1 |                    1 |
|  2 | HP       | Percentage    |     1 |                    1 |
|  3 | HP       | Add           |     1 |                    2 |
|  4 | HP       | Percentage    |     1 |                    2 |
+----+----------+---------------+-------+----------------------+

@ipdae ipdae self-assigned this Feb 14, 2024
@ipdae ipdae requested review from area363 and a team February 14, 2024 13:47
@ipdae ipdae added the enhancement New feature or request label Feb 14, 2024

This PR has 261 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +251 -10
Percentile : 66.1%

Total files changed: 13

Change summary by file extension:
.cs : +250 -9
.Headless : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

1 similar comment

This PR has 261 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +251 -10
Percentile : 66.1%

Total files changed: 13

Change summary by file extension:
.cs : +250 -9
.Headless : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

This PR has 261 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!


Quantification details

Label      : Large
Size       : +251 -10
Percentile : 66.1%

Total files changed: 13

Change summary by file extension:
.cs : +250 -9
.Headless : +1 -1

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.


Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@ipdae ipdae changed the base branch from development to feature/colleciton February 16, 2024 09:52
@ipdae ipdae merged commit 70df697 into planetarium:feature/colleciton Feb 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Large
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

콜렉션 데이터 베이스 마이그레이션
3 participants