Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback graphql api type #619

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Rollback graphql api type #619

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion NineChronicles.DataProvider.Tests/WorldBossRankingQueryTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,8 @@ public async Task WorldBossRanking(bool hex)
var models = (object[]) data["rankingInfo"];
Assert.Equal(101, models.Length);
var raider = (Dictionary<string, object>)models.Last();
Assert.Equal(targetAvatarAddress.ToString(), raider["address"]);
// FIXME should be use AddressType
Assert.Equal(targetAvatarAddress.ToHex(), raider["address"]);
}

[Fact]
Expand Down
6 changes: 4 additions & 2 deletions NineChronicles.DataProvider/GraphTypes/WorldBossRankingType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,12 @@ public WorldBossRankingType()
description: "Season ranking.",
resolve: context => context.Source.Ranking
);
Field<NonNullGraphType<AddressType>>(

// FIXME should be use AddressType
Field<NonNullGraphType<StringGraphType>>(
nameof(WorldBossRankingModel.Address),
description: "Address of avatar.",
resolve: context => new Address(context.Source.Address!)
resolve: context => context.Source.Address
);
Field<NonNullGraphType<StringGraphType>>(
nameof(WorldBossRankingModel.AvatarName),
Expand Down
Loading