Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce filtered argument at .nodeStatus.stagedTxIds[Count] #2563

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

moreal
Copy link
Contributor

@moreal moreal commented Aug 30, 2024

Since stagedTxIds and stagedTxIdsCount field uses BlockChain.GetStagedTransactionIds method, it uses IStagePolicy.Iterate(BlockChain chain, bool filtered) with filtered=true. But we cannot know how many real transactions are staged now because it must not filter transactions to know that.

This pull request replaces BlockChain.GetStagedTransactionIds() call with IStagePolicy.Iterate(...) and introduces filtered query argument for .nodeStatus.stagedTxIds and .nodeStatus.stagedTxIdsCount fields.

@moreal moreal self-assigned this Aug 30, 2024
@auto-assign auto-assign bot requested review from area363 and ipdae August 30, 2024 08:15
@moreal moreal force-pushed the bugfix/stagedTxIdsCount branch 3 times, most recently from 88ce23b to 9fbdec4 Compare September 6, 2024 04:42
@moreal moreal force-pushed the bugfix/stagedTxIdsCount branch 3 times, most recently from fc81cba to 7bc6405 Compare September 10, 2024 06:32
@ipdae
Copy link
Member

ipdae commented Sep 11, 2024

이건 @planetarium/libplanet 팀에서 봐주시는게 좋을것같습니다.

@moreal moreal force-pushed the bugfix/stagedTxIdsCount branch from 7bc6405 to 7dba510 Compare September 20, 2024 11:39
@moreal moreal force-pushed the bugfix/stagedTxIdsCount branch from 7dba510 to 9f122bc Compare September 25, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants