Bump xunit from 2.4.1 to 2.9.2 #13380
Annotations
10 errors and 11 warnings
build:
.Lib9c.Tests/Model/AdventureBoss/AdventureBossSimulatorTest.cs#L40
Test methods must have a supported return type. Valid types are: void, Task. Change the return type to one of the compatible types.
|
build:
.Lib9c.Tests/Action/ReRegisterProductTest.cs#L241
Do not use Assert.Equal() to check for collection size. Use Assert.Single instead.
|
build:
.Lib9c.Tests/Action/Scenario/RuneScenarioTest.cs#L111
Do not use a Where clause to filter before calling Assert.Single. Use the overload of Assert.Single that accepts a filtering function.
|
build:
.Lib9c.Tests/Action/Scenario/RuneScenarioTest.cs#L112
Do not use a Where clause to filter before calling Assert.Single. Use the overload of Assert.Single that accepts a filtering function.
|
build:
.Lib9c.Tests/Action/GrindingTest.cs#L337
Do not use Assert.True(false, message) to fail a test. Use Assert.Fail(message) instead.
|
build:
.Lib9c.Tests/Model/State/ShopStateTest.cs#L45
Do not use Assert.Equal() to check for collection size. Use Assert.Single instead.
|
build:
.Lib9c.Tests/Model/State/ShopStateTest.cs#L79
Do not use Assert.Equal() to check for collection size. Use Assert.Single instead.
|
build:
.Lib9c.Tests/Model/State/ShopStateTest.cs#L146
Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead.
|
build:
.Lib9c.Tests/Model/State/ShopStateTest.cs#L186
Do not use Assert.Equal() to check for collection size. Use Assert.Empty instead.
|
build:
.Lib9c.Tests/Model/State/ActivatedAccountsStateTest.cs#L22
Comparing an instance of System.Collections.Immutable.ImmutableHashSet<Libplanet.Crypto.Address> with an instance of System.Collections.Immutable.IImmutableSet<Libplanet.Crypto.Address> has undefined results, because the order of items in the set is not predictable. Create a stable order for the set (i.e., by using OrderBy from Linq).
|
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-dotnet@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
build:
.Libplanet/src/Libplanet.Store/BlockSet.cs#L160
Converting null literal or possible null value to non-nullable type.
|
build:
.Libplanet/src/Libplanet.Action/IPolicyActionsRegistry.cs#L14
Elements should be separated by blank line
|
build:
.Libplanet/src/Libplanet.Action/IPolicyActionsRegistry.cs#L21
Elements should be separated by blank line
|
build:
.Libplanet/src/Libplanet.Action/IPolicyActionsRegistry.cs#L28
Elements should be separated by blank line
|
build:
.Libplanet/src/Libplanet.Action/IPolicyActionsRegistry.cs#L13
Closing brace should be followed by blank line
|
build:
.Libplanet/src/Libplanet.Action/IPolicyActionsRegistry.cs#L20
Closing brace should be followed by blank line
|
build:
.Libplanet/src/Libplanet.Action/IPolicyActionsRegistry.cs#L27
Closing brace should be followed by blank line
|
build:
.Libplanet/src/Libplanet.Action/IPolicyActionsRegistry.cs#L14
Single-line comment should be preceded by blank line
|
build:
.Libplanet/src/Libplanet.Action/IPolicyActionsRegistry.cs#L21
Single-line comment should be preceded by blank line
|
build:
.Libplanet/src/Libplanet.Action/IPolicyActionsRegistry.cs#L28
Single-line comment should be preceded by blank line
|
Loading