Skip to content

Commit

Permalink
Add SKillId on ArenaSkill
Browse files Browse the repository at this point in the history
  • Loading branch information
ipdae committed May 16, 2024
1 parent 8392014 commit d6c1b5b
Show file tree
Hide file tree
Showing 23 changed files with 39 additions and 24 deletions.
3 changes: 2 additions & 1 deletion Lib9c/Model/BattleStatus/Arena/ArenaAreaAttack.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@ namespace Nekoyume.Model.BattleStatus.Arena
public class ArenaAreaAttack : ArenaSkill
{
public ArenaAreaAttack(
int skillId,
ArenaCharacter character,
IEnumerable<ArenaSkillInfo> skillInfos,
IEnumerable<ArenaSkillInfo> buffInfos)
: base(character, skillInfos, buffInfos)
: base(skillId, character, skillInfos, buffInfos)
{
}

Expand Down
3 changes: 2 additions & 1 deletion Lib9c/Model/BattleStatus/Arena/ArenaBlowAttack.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@ namespace Nekoyume.Model.BattleStatus.Arena
public class ArenaBlowAttack : ArenaSkill
{
public ArenaBlowAttack(
int skillId,
ArenaCharacter character,
IEnumerable<ArenaSkillInfo> skillInfos,
IEnumerable<ArenaSkillInfo> buffInfos)
: base(character, skillInfos, buffInfos)
: base(skillId, character, skillInfos, buffInfos)
{
}

Expand Down
4 changes: 2 additions & 2 deletions Lib9c/Model/BattleStatus/Arena/ArenaBuff.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ namespace Nekoyume.Model.BattleStatus.Arena
[Serializable]
public class ArenaBuff : ArenaSkill
{
public ArenaBuff(ArenaCharacter character, IEnumerable<ArenaSkillInfo> skillInfos)
: base(character, skillInfos, null)
public ArenaBuff(int skillId, ArenaCharacter character, IEnumerable<ArenaSkillInfo> skillInfos)
: base(skillId, character, skillInfos, null)
{
}

Expand Down
3 changes: 2 additions & 1 deletion Lib9c/Model/BattleStatus/Arena/ArenaBuffRemovalAttack.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@ namespace Nekoyume.Model.BattleStatus.Arena
public class ArenaBuffRemovalAttack : ArenaSkill
{
public ArenaBuffRemovalAttack(
int skillId,
ArenaCharacter character,
IEnumerable<ArenaSkillInfo> skillInfos,
IEnumerable<ArenaSkillInfo> buffInfos)
: base(character, skillInfos, buffInfos)
: base(skillId, character, skillInfos, buffInfos)
{
}

Expand Down
3 changes: 2 additions & 1 deletion Lib9c/Model/BattleStatus/Arena/ArenaDoubleAttack.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@ namespace Nekoyume.Model.BattleStatus.Arena
public class ArenaDoubleAttack : ArenaSkill
{
public ArenaDoubleAttack(
int skillId,
ArenaCharacter character,
IEnumerable<ArenaSkillInfo> skillInfos,
IEnumerable<ArenaSkillInfo> buffInfos)
: base(character, skillInfos, buffInfos)
: base(skillId, character, skillInfos, buffInfos)
{
}

Expand Down
3 changes: 2 additions & 1 deletion Lib9c/Model/BattleStatus/Arena/ArenaDoubleAttackWithCombo.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@ namespace Nekoyume.Model.BattleStatus.Arena
public class ArenaDoubleAttackWithCombo : ArenaSkill
{
public ArenaDoubleAttackWithCombo(
int skillId,
ArenaCharacter character,
IEnumerable<ArenaSkillInfo> skillInfos,
IEnumerable<ArenaSkillInfo> buffInfos)
: base(character, skillInfos, buffInfos)
: base(skillId, character, skillInfos, buffInfos)
{
}

Expand Down
3 changes: 2 additions & 1 deletion Lib9c/Model/BattleStatus/Arena/ArenaHeal.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@ namespace Nekoyume.Model.BattleStatus.Arena
public class ArenaHeal : ArenaSkill
{
public ArenaHeal(
int skillId,
ArenaCharacter character,
IEnumerable<ArenaSkillInfo> skillInfos,
IEnumerable<ArenaSkillInfo> buffInfos)
: base(character, skillInfos, buffInfos)
: base(skillId, character, skillInfos, buffInfos)
{
}

Expand Down
3 changes: 2 additions & 1 deletion Lib9c/Model/BattleStatus/Arena/ArenaNormalAttack.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@ namespace Nekoyume.Model.BattleStatus.Arena
public class ArenaNormalAttack : ArenaSkill
{
public ArenaNormalAttack(
int skillId,
ArenaCharacter character,
IEnumerable<ArenaSkillInfo> skillInfos,
IEnumerable<ArenaSkillInfo> buffInfos)
: base(character, skillInfos, buffInfos)
: base(skillId, character, skillInfos, buffInfos)
{
}

Expand Down
3 changes: 2 additions & 1 deletion Lib9c/Model/BattleStatus/Arena/ArenaShatterStrike.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,11 @@ namespace Nekoyume.Model.BattleStatus.Arena
public class ArenaShatterStrike : ArenaSkill
{
public ArenaShatterStrike(
int skillId,
ArenaCharacter character,
IEnumerable<ArenaSkillInfo> skillInfos,
IEnumerable<ArenaSkillInfo> buffInfos
) : base(character, skillInfos, buffInfos)
) : base(skillId, character, skillInfos, buffInfos)
{
}

Expand Down
5 changes: 4 additions & 1 deletion Lib9c/Model/BattleStatus/Arena/ArenaSkill.cs
Original file line number Diff line number Diff line change
Expand Up @@ -47,17 +47,20 @@ public ArenaSkillInfo(ArenaCharacter character, long effect, bool critical, Skil
}
}

public readonly IEnumerable<ArenaSkillInfo> SkillInfos;
public readonly int SkillId;

public readonly IEnumerable<ArenaSkillInfo> SkillInfos;

public readonly IEnumerable<ArenaSkillInfo>? BuffInfos;

protected ArenaSkill(
int skillId,
ArenaCharacter character,
IEnumerable<ArenaSkillInfo> skillInfos,
IEnumerable<ArenaSkillInfo> buffInfos)
: base(character)
{
SkillId = skillId;
SkillInfos = skillInfos;
BuffInfos = buffInfos;
}
Expand Down
5 changes: 3 additions & 2 deletions Lib9c/Model/BattleStatus/Arena/ArenaTick.cs
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,15 @@ namespace Nekoyume.Model.BattleStatus.Arena
public class ArenaTick : ArenaSkill
{
public ArenaTick(ArenaCharacter character) : this(
0,
character,
ArraySegment<ArenaSkillInfo>.Empty,
ArraySegment<ArenaSkillInfo>.Empty)
{
}

public ArenaTick(ArenaCharacter character, IEnumerable<ArenaSkillInfo> skillInfos, IEnumerable<ArenaSkillInfo> buffInfos)
: base(character, skillInfos, buffInfos)
public ArenaTick(int skillId, ArenaCharacter character, IEnumerable<ArenaSkillInfo> skillInfos, IEnumerable<ArenaSkillInfo> buffInfos)
: base(skillId, character, skillInfos, buffInfos)
{
}

Expand Down
4 changes: 2 additions & 2 deletions Lib9c/Model/BattleStatus/Arena/ArenaTickDamage.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ namespace Nekoyume.Model.BattleStatus.Arena
[Serializable]
public class ArenaTickDamage : ArenaSkill
{
public ArenaTickDamage(ArenaCharacter character, IEnumerable<ArenaSkillInfo> skillInfos, IEnumerable<ArenaSkillInfo> buffInfos)
: base(character, skillInfos, buffInfos)
public ArenaTickDamage(int skillId, ArenaCharacter character, IEnumerable<ArenaSkillInfo> skillInfos, IEnumerable<ArenaSkillInfo> buffInfos)
: base(skillId, character, skillInfos, buffInfos)
{
}

Expand Down
1 change: 1 addition & 0 deletions Lib9c/Model/Buff/Bleed.cs
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ public ArenaSkill GiveEffectForArena(
};

return new ArenaTickDamage(
RowData.Id,
clone,
damageInfos,
null);
Expand Down
1 change: 1 addition & 0 deletions Lib9c/Model/Buff/Vampiric.cs
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ public ArenaSkill GiveEffectForArena(ArenaCharacter affectedCharacter, ArenaSkil
RowData.TargetType)
};
return new ArenaTick(
RowData.Id,
clone,
infos,
null);
Expand Down
1 change: 1 addition & 0 deletions Lib9c/Model/Character/ArenaCharacter.cs
Original file line number Diff line number Diff line change
Expand Up @@ -665,6 +665,7 @@ private ArenaSkill GiveThornDamage(long targetThorn)
};

var tickDamage = new ArenaTickDamage(
default,
clone,
damageInfos,
null);
Expand Down
2 changes: 1 addition & 1 deletion Lib9c/Model/Skill/Arena/ArenaAreaAttack.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public override BattleStatus.Arena.ArenaSkill Use(
var damage = ProcessDamage(caster, target, turn);
var buff = ProcessBuff(caster, target, turn, buffs);

return new BattleStatus.Arena.ArenaAreaAttack(clone, damage, buff);
return new BattleStatus.Arena.ArenaAreaAttack(SkillRow.Id, clone, damage, buff);
}
}
}
2 changes: 1 addition & 1 deletion Lib9c/Model/Skill/Arena/ArenaBlowAttack.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public override BattleStatus.Arena.ArenaSkill Use(
var damage = ProcessDamage(caster, target, turn);
var buff = ProcessBuff(caster, target, turn, buffs);

return new BattleStatus.Arena.ArenaBlowAttack(clone, damage, buff);
return new BattleStatus.Arena.ArenaBlowAttack(SkillRow.Id, clone, damage, buff);
}
}
}
2 changes: 1 addition & 1 deletion Lib9c/Model/Skill/Arena/ArenaBuffRemovalAttack.cs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public override BattleStatus.Arena.ArenaSkill Use(
var buff = ProcessBuff(caster, target, turn, buffs);
target.RemoveRecentStatBuff();

return new BattleStatus.Arena.ArenaBuffRemovalAttack(clone, damage, buff);
return new BattleStatus.Arena.ArenaBuffRemovalAttack(SkillRow.Id, clone, damage, buff);
}
}
}
2 changes: 1 addition & 1 deletion Lib9c/Model/Skill/Arena/ArenaBuffSkill.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ public override BattleStatus.Arena.ArenaSkill Use(
var clone = (ArenaCharacter)caster.Clone();
var buff = ProcessBuff(caster, target, turn, buffs);

return new BattleStatus.Arena.ArenaBuff(clone, buff);
return new BattleStatus.Arena.ArenaBuff(SkillRow.Id, clone, buff);
}
}
}
4 changes: 2 additions & 2 deletions Lib9c/Model/Skill/Arena/ArenaDoubleAttack.cs
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ public override BattleStatus.Arena.ArenaSkill Use(

if (SkillRow.Combo)
{
return new BattleStatus.Arena.ArenaDoubleAttackWithCombo(clone, damage, buff);
return new BattleStatus.Arena.ArenaDoubleAttackWithCombo(SkillRow.Id, clone, damage, buff);
}
else
{
return new BattleStatus.Arena.ArenaDoubleAttack(clone, damage, buff);
return new BattleStatus.Arena.ArenaDoubleAttack(SkillRow.Id, clone, damage, buff);
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion Lib9c/Model/Skill/Arena/ArenaHealSkill.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public override BattleStatus.Arena.ArenaSkill Use(
var heal = ProcessHeal(caster, turn);
var buff = ProcessBuff(caster, target, turn, buffs);

return new BattleStatus.Arena.ArenaHeal(clone, heal, buff);
return new BattleStatus.Arena.ArenaHeal(SkillRow.Id, clone, heal, buff);
}

private IEnumerable<BattleStatus.Arena.ArenaSkill.ArenaSkillInfo> ProcessHeal(
Expand Down
2 changes: 1 addition & 1 deletion Lib9c/Model/Skill/Arena/ArenaNormalAttack.cs
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public override BattleStatus.Arena.ArenaSkill Use(
var damage = ProcessDamage(caster, target, turn, true);
var buff = ProcessBuff(caster, target, turn, buffs);

return new BattleStatus.Arena.ArenaNormalAttack(clone, damage, buff);
return new BattleStatus.Arena.ArenaNormalAttack(SkillRow.Id, clone, damage, buff);
}
}
}
2 changes: 1 addition & 1 deletion Lib9c/Model/Skill/Arena/ArenaShatterStrike.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public override BattleStatus.Arena.ArenaSkill Use(ArenaCharacter caster, ArenaCh
var damage = ProcessDamage(caster, target, turn);
var buff = ProcessBuff(caster, target, turn, buffs);

return new BattleStatus.Arena.ArenaShatterStrike(clone, damage, buff);
return new BattleStatus.Arena.ArenaShatterStrike(SkillRow.Id, clone, damage, buff);
}
}
}

0 comments on commit d6c1b5b

Please sign in to comment.