Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce AdventureBossSimulator #2611

Merged
merged 11 commits into from
Jun 10, 2024
Merged

Introduce AdventureBossSimulator #2611

merged 11 commits into from
Jun 10, 2024

Conversation

U-lis
Copy link
Contributor

@U-lis U-lis commented Jun 4, 2024

This simulator is based on StageSimulator
AdventureBoss uses FloorId instead of StageId

@U-lis U-lis added the enhancement New feature or request label Jun 4, 2024
@U-lis U-lis added this to the v200.0.0 milestone Jun 4, 2024
@U-lis U-lis self-assigned this Jun 4, 2024
This was linked to issues Jun 4, 2024
어드벤쳐 보스 전투 #2551
Closed
AdventureBoss Simulator #2567
Closed
@U-lis U-lis marked this pull request as ready for review June 4, 2024 08:31
jonny-jeahyunchoi
jonny-jeahyunchoi reviewed Jun 7, 2024
View reviewed changes
Copy link
Contributor

@jonny-jeahyunchoi jonny-jeahyunchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SweepAdventureBoss Action도 GameAction을 상속받아 ID를 사용할수있도록 하는것이 좋을것같습니다. 클라에서 전투시 ID기준으로 체크하는것들이 있어서요 (ex IsLastBattleActionId)

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jun 10, 2024 •
edited
Loading

Deploying lib9c with  Cloudflare Pages  Cloudflare Pages

Latest commit: 58a418c
Status:🚫  Build failed.

View logs

@U-lis U-lis merged commit cebc0a5 into feature/adventure-boss Jun 10, 2024
15 of 16 checks passed
@U-lis U-lis linked an issue Jun 14, 2024 that may be closed by this pull request
Adventure Boss 사후리뷰 #2630
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonny-jeahyunchoi jonny-jeahyunchoi jonny-jeahyunchoi left review comments

@ipdae ipdae Awaiting requested review from ipdae

Assignees

@U-lis U-lis

Labels
enhancement New feature or request
Projects
Nine Chronicles
Archived in project
Milestone
v200.0.0
Development

Successfully merging this pull request may close these issues.

Adventure Boss 사후리뷰 AdventureBoss Simulator 어드벤쳐 보스 전투
2 participants
@U-lis @jonny-jeahyunchoi