Bugfix/fix mead #2668
Merged
Bugfix/fix mead #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
limebell
force-pushed
the
bugfix/fix-mead
branch
2 times, most recently
from
2a6f2e0
to
5d13047
Compare
limebell
requested review from
boscohyun,
sonohoshi and
tyrosine1153
as code owners
boscohyun
reviewed
Jul 12, 2024
| @@ -38,7 +38,7 @@ public override void LoadPlainValue(IValue plainValue) | |||
|
|
|||
| public override IWorld Execute(IActionContext context) | |||
| { | |||
| context.UseGas(1); | |||
There was a problem hiding this comment.
Is RewardGold action no longer gassing?
There was a problem hiding this comment.
Despite of the line, it was treated as a BlockAction, so it did not consume gas actually at the libplanet level before. With changes in how actions are processed in libplanet, keeping that line could potentially cause issues, which is why it has been removed to maintain consistency with previous behavior.
and fix error deserializing WithdrawDelegator action
limebell
force-pushed
the
bugfix/fix-mead
branch
from
2ca988f
to
8d3466a
Compare
limebell
force-pushed
the
bugfix/fix-mead
branch
from
8d3466a
to
3e563e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.