-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/fix mead #2668
Bugfix/fix mead #2668
Conversation
2a6f2e0
to
5d13047
Compare
@@ -38,7 +38,7 @@ public override void LoadPlainValue(IValue plainValue) | |||
|
|||
public override IWorld Execute(IActionContext context) | |||
{ | |||
context.UseGas(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is RewardGold
action no longer gassing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite of the line, it was treated as a BlockAction
, so it did not consume gas actually at the libplanet level before. With changes in how actions are processed in libplanet, keeping that line could potentially cause issues, which is why it has been removed to maintain consistency with previous behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation!
and fix error deserializing WithdrawDelegator action
2ca988f
to
8d3466a
Compare
8d3466a
to
3e563e4
Compare
No description provided.