Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GameConfig 정리 #2681

Merged
merged 5 commits into from
Jul 19, 2024
Merged

GameConfig 정리 #2681

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
af597cf
refactor IsEditor field
eugene-doobu Jul 11, 2024
2d48971
remove unused fields
eugene-doobu Jul 11, 2024
5722f4e
remove redundant fields
eugene-doobu Jul 11, 2024
16e777e
Merge remote-tracking branch 'origin/development' into feature/reduce…
eugene-doobu Jul 16, 2024
dc840f7
Merge branch 'development' into feature/reduce-conditional-compilation
eugene-doobu Jul 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions Lib9c/GameConfig.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,21 +4,16 @@ namespace Nekoyume
{
public static class GameConfig
{
// ReSharper disable once ConvertToConstant.Global
#if LIB9C_DEV_EXTENSIONS || UNITY_EDITOR
public const bool IsEditor = true;
public static readonly bool IsEditor = true;
#else
public const bool IsEditor = false;
public static readonly bool IsEditor = false;
#endif

public const int SlotCount = 3;
public const float WaitSeconds = 180f;
public const string AvatarNickNamePattern = @"^[0-9a-zA-Z]{2,20}$";
public const string DiscordLink = "https://discord.gg/NqshYve";

public const string BlockExplorerLinkFormat =
"http://explorer.libplanet.io/9c-beta/account/?{0}";

public const float PlayerSpeechBreakTime = 2f;
public const int MimisbrunnrWorldId = 10001;
public const int MimisbrunnrStartStageId = 10000001;
public const int DefaultAttackId = 100000;
Expand All @@ -33,15 +28,8 @@ public static class GameConfig
public const int DefaultAvatarArmorId = 10200000;

//TODO 안쓰는 프리팹과 함께 삭제해야함
public const int CombineEquipmentCostAP = 5;
public const int CombineEquipmentCostNCG = 10;
public const int EnhanceEquipmentCostAP = 0;

public const int RankingRewardFirst = 50;
public const int RankingRewardSecond = 30;
public const int RankingRewardThird = 10;

public const int ArenaActivationCostNCG = 100;
public const int ArenaScoreDefault = 1000;
public const int ArenaChallengeCountMax = 5;
public const int MaximumProbability = 10000;
Expand Down
5 changes: 0 additions & 5 deletions Lib9c/TableData/Item/ItemRequirementSheet.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,8 @@ public class Row : SheetRow<int>
public override void Set(IReadOnlyList<string> fields)
{
ItemId = ParseInt(fields[0]);
#if UNITY_EDITOR
Level = GameConfig.IsEditor ? 1 : ParseInt(fields[1]);
MimisLevel = GameConfig.IsEditor ? 1 : ParseInt(fields[2]);
#else
Level = ParseInt(fields[1]);
MimisLevel = ParseInt(fields[2]);
#endif
}
}

Expand Down
Loading