code sweep create avatar action #2919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
U-lis
approved these changes
Oct 23, 2024
ipdae
reviewed
Oct 23, 2024
| @@ -306,6 +275,134 @@ public static AvatarState CreateAvatarState(string name, | |||
| ); | |||
|
|
|||
| #if LIB9C_DEV_EXTENSIONS || UNITY_EDITOR | |||
| AddTestItems(ctx, avatarState, random, materialItemSheet); | |||
There was a problem hiding this comment.
이 메서드도 ExecuteDevExtensions 안에서 처리할수 있는것처럼 보이는데, 맞을까요?
There was a problem hiding this comment.
의도 파악을 정확히 못했는데, 데브 환경에서만 materialItemSheet에 있는 아이템 뿌려주는 거라면 ExecuteDevExtensions 안에 통합해도 될 것 같습니다
There was a problem hiding this comment.
277에서 이미 조건으로 데브환경에서만 돌도록 처리한것처럼 보여서 질문드린거였습니다. 머지 블로커는 아닌것같습니다.
There was a problem hiding this comment.
관련해서 후속 이슈 만들어서 진행할 것들이 있어 합쳐서 문제 없다면 거기서 합쳐보도록 하겠습니다
#2936
ipdae
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA
기능 변경 없이 메서드 등으로 코드 정리
유니티 에디터 로컬(디버그)모드와 테스트로 확인 진행했습니다