feat: Remove Vote.Verify()

planetarium · Jun 20, 2024 · f13ade5 · f13ade5
1 parent dd7f770
commit f13ade5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 20 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -14,6 +14,7 @@ To be released.
     [[#3811]]
  -  (Libplanet) `BlockChain.DetermineBlockStateRootHash()`
     has been removed.  [[#3811]]
+ -  (Libplanet.Types) `Vote.Verify()` has been removed.  [[#3837]]
 
 ### Backward-incompatible API changes
 
@@ -63,6 +64,7 @@ To be released.
 ### CLI tools
 
 [#3811]: https://github.com/planetarium/libplanet/pull/3811
+[#3837]: https://github.com/planetarium/libplanet/pull/3837
 
 
 Version 4.6.1

diff --git a/Libplanet.Net/Consensus/HeightVoteSet.cs b/Libplanet.Net/Consensus/HeightVoteSet.cs
@@ -120,11 +120,6 @@ public void AddVote(Vote vote)
 
                 PublicKey validatorKey = vote.ValidatorPublicKey;
 
-                if (validatorKey is null)
-                {
-                    throw new InvalidVoteException("ValidatorKey of the vote cannot be null", vote);
-                }
-
                 if (!_validatorSet.ContainsPublicKey(validatorKey))
                 {
                     throw new InvalidVoteException(
@@ -140,10 +135,10 @@ public void AddVote(Vote vote)
                         vote);
                 }
 
-                if (!vote.Verify())
+                if (vote.Signature.IsEmpty)
                 {
                     throw new InvalidVoteException(
-                        "Received vote's signature is invalid",
+                        "Received vote's signature is empty",
                         vote);
                 }
 

diff --git a/Libplanet.Types/Consensus/Vote.cs b/Libplanet.Types/Consensus/Vote.cs
@@ -117,19 +117,6 @@ private Vote(Bencodex.Types.Dictionary encoded)
                 ? ((Bencodex.Types.Dictionary)_metadata.Bencoded).Add(SignatureKey, Signature)
                 : _metadata.Bencoded;
 
-        /// <summary>
-        /// Verifies whether the <see cref="Vote"/>'s payload is properly signed by
-        /// <see cref="Validator"/>.
-        /// </summary>
-        /// <returns><see langword="true"/> if the <see cref="Signature"/> is not empty
-        /// and is a valid signature signed by <see cref="Validator"/>,
-        /// <see langword="false"/> otherwise.</returns>
-        [Pure]
-        public bool Verify() =>
-            !Signature.IsEmpty &&
-            ValidatorPublicKey.Verify(
-                _codec.Encode(_metadata.Bencoded).ToImmutableArray(), Signature);
-
         /// <inheritdoc/>
         [Pure]
         public bool Equals(Vote? other)